[capstone] Use static runtime if capstone wants to be statically linked #23122

illera88 · 2022-02-16T03:32:16Z

Describe the pull request
This makes more sense than using the shared runtime if building a static version

Which triplets are supported/not supported? Have you updated the [CI baseline]

All

Does your PR follow the maintainer guide?

Yes

This makes more sense than using the shared runtime if building a static version

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for capstone but no changes to version or port version.
-- Version: 4.0.2#2
-- Old SHA: 465e527988f09c855e156cff45b7ee6dfbe1d303
-- New SHA: b2a7400a309296912c2dd2297f4ff69635bc1ab3
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

JonLiu1993 · 2022-02-16T06:34:23Z

@illera88 ,Thanks for your pr, please add "port-version" to 3 in vcpkg.json file, and run the command "./vcpkg x-add-version capstone --overwrite-version" and commit again

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 016788b220b5063fa5e73e6f7ad56283d239727a -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/capstone.json b/versions/c-/capstone.json
index 0120f1c..c84f450 100644
--- a/versions/c-/capstone.json
+++ b/versions/c-/capstone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "b2a7400a309296912c2dd2297f4ff69635bc1ab3",
+      "git-tree": "cd9d058e677f9ce4c6488fcf65519cac2380bf4e",
       "version": "4.0.2",
       "port-version": 3
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

illera88 · 2022-02-16T07:10:54Z

@illera88 ,Thanks for your pr, please add "port-version" to 3 in vcpkg.json file, and run the command "./vcpkg x-add-version capstone --overwrite-version" and commit again

done

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/capstone/vcpkg.json b/ports/capstone/vcpkg.json
index bc98060..70a2e92 100644
--- a/ports/capstone/vcpkg.json
+++ b/ports/capstone/vcpkg.json
@@ -35,6 +35,9 @@
     "sparc": {
       "description": "Capstone disassembly support for SPARC"
     },
+    "static-crt": {
+      "description": "Use Windows C Runtime Library (CRT)"
+    },
     "sysz": {
       "description": "Capstone disassembly support for SysZ"
     },
@@ -57,9 +60,6 @@
     },
     "xcore": {
       "description": "Capstone disassembly support for XCore"
-    },
-    "static-crt": {
-      "description": "Use Windows C Runtime Library (CRT)"
     }
   }
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 016788b220b5063fa5e73e6f7ad56283d239727a -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/capstone.json b/versions/c-/capstone.json
index c84f450..628c61b 100644
--- a/versions/c-/capstone.json
+++ b/versions/c-/capstone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "cd9d058e677f9ce4c6488fcf65519cac2380bf4e",
+      "git-tree": "4eed56c89ad566ab6cbc95822c121ecf23c46663",
       "version": "4.0.2",
       "port-version": 3
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

ports/capstone/portfile.cmake

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 016788b220b5063fa5e73e6f7ad56283d239727a -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/capstone.json b/versions/c-/capstone.json
index 628c61b..3d3dce3 100644
--- a/versions/c-/capstone.json
+++ b/versions/c-/capstone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "4eed56c89ad566ab6cbc95822c121ecf23c46663",
+      "git-tree": "322179773392d3ceb4d8ae894faa968a18375f79",
       "version": "4.0.2",
       "port-version": 3
     },

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/capstone/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

illera88 · 2022-02-21T02:28:41Z

Same problem applies. You are passing the CAPSTONE_HAS_OSXKERNEL flag and therefore this code is compiled:

#if defined(CAPSTONE_HAS_OSXKERNEL)
#include <Availability.h>
#include <libkern/libkern.h>
#else
#include <stdlib.h>
#endif

and both:

#include <Availability.h>
#include <libkern/libkern.h>

are not present under Windows. You can't do ./vcpkg install capstone[*] in either Windows or Linux or you will run in the same problem.

But I don't think it's an error per se. You are indicating Capstone that you have a OSX Kernel in a Windows system which is not true.

JackBoosY · 2022-02-21T07:08:43Z

If some features are not applicable to some triplets, please add the following code before vcpkg_configure_cmake in portfile.cmake:

if ("xcore" IN_LIST FEATURES AND VCPKG_TARGET_IS_WINDOWS)
    message(FATAL_ERROR "Feature 'xcore' doesn't support Windows")
endif()

illera88 · 2022-02-21T08:03:27Z

I can do that but in that case doing:

./vcpkg install capstone[*]

will fail

JonLiu1993 · 2022-02-21T08:05:58Z

I can do that but in that case doing:
./vcpkg install capstone[*]
will fail

Could you provide the error log?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 016788b220b5063fa5e73e6f7ad56283d239727a -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/capstone.json b/versions/c-/capstone.json
index bfa92dd..686d3b8 100644
--- a/versions/c-/capstone.json
+++ b/versions/c-/capstone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "ed177dc3e8523b026a70639ccf7882714d0a7995",
+      "git-tree": "1e645c65b70b5ee6e94a9371b479822524fba1c9",
       "version": "4.0.2",
       "port-version": 3
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

illera88 · 2022-02-21T08:13:57Z

Last commit adds mentioned checks

ports/capstone/portfile.cmake

…her ports (Triton)

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 016788b220b5063fa5e73e6f7ad56283d239727a -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/capstone.json b/versions/c-/capstone.json
index 686d3b8..dbb1e6e 100644
--- a/versions/c-/capstone.json
+++ b/versions/c-/capstone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1e645c65b70b5ee6e94a9371b479822524fba1c9",
+      "git-tree": "b17d5e945550d7a601132fc223d112dd87990209",
       "version": "4.0.2",
       "port-version": 3
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 016788b220b5063fa5e73e6f7ad56283d239727a -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/c-/capstone.json b/versions/c-/capstone.json
index dbb1e6e..6c1661c 100644
--- a/versions/c-/capstone.json
+++ b/versions/c-/capstone.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "b17d5e945550d7a601132fc223d112dd87990209",
+      "git-tree": "5250715402bf0c970792dafe6947aa810adde0f1",
       "version": "4.0.2",
       "port-version": 3
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

@acidicoala

84: Pass StartDate and EndDate to Get-MergedPullRequests instead of special casing only Credentials 109+130: Fix calculating negative progress caused by seeing PRs in the future because GitHub returns times in UTC 268: Actually make filtering for infrastructure PRs functional 303: Fix extraction of port-version from vcpkg.json. This really should be handled by diffing baseline.json in the future. 374-382: Fix expression ordering and casting problem which prevented non-CONTROL ports from ever being considered "new" Also skip emitting headers for empty blocks, update and sort current triplet list, and move infrastructure bits below port modifications. Example output: vcpkg (2022.02.19 - 2022.02.22) --- #### Total port count: #### Total port count per triplet (tested): |triplet|ports available| |---|---| |x86-windows|NUM| |**x64-windows**|NUM| |x64-windows-static|NUM| |x64-windows-static-md|NUM| |x64-uwp|NUM| |arm64-windows|NUM| |arm-uwp|NUM| |**x64-osx**|NUM| |**x64-linux**|NUM| <details> <summary><b>The following 2 ports have been added:</b></summary> |port|version| |---|---| |[libcurl-simple-https](microsoft#22917 |[triton](microsoft#23111 </details> <details> <summary><b>The following 18 ports have been updated:</b></summary> - polyhook2 `2022-02-06#0` -> `2022-02-21#0` - [(microsoft#23203)](microsoft#23203) [polyhook2] Update to latest (2022-02-21) (by @acidicoala) - graphviz `2.49.1#1` -> `2.49.1#2` - [(microsoft#23148)](microsoft#23148) [graphviz] Fix tools (by @Ace314159) - itk `5.1.0#7` -> `5.2.1#0` - [(microsoft#23158)](microsoft#23158) [ITK] update to v5.2.1 (by @Adela0814) - qhull `8.0.2#2` -> `8.0.2#3` - [(microsoft#23129)](microsoft#23129) [qhull] Fix copyright, pc files, cmake usage (by @dg0yt) - tgui `2021-04-19#2` -> `2021-04-19#3` - [(microsoft#23211)](microsoft#23211) [tgui] fix absolute paths (by @autoantwort) - json-dto `0.3.0#0` -> `0.3.1#0` - [(microsoft#23224)](microsoft#23224) [json-dto] Update to 0.3.1 (by @eao197) - leveldb `1.22#4` -> `1.22#5` - [(microsoft#23180)](microsoft#23180) [leveldb] Fix homepage (by @MarcoFalke) - openxr-loader `1.0.22#0` -> `1.0.22#1` - [(microsoft#23191)](microsoft#23191) [openxr-loader] Fix build failure in world rebuild CI. (by @Hoikas) - ngspice `35#1` -> `35#2` - [(microsoft#23151)](microsoft#23151) [ngspice] Fix error C2065 (by @Cheney-W) - openmvg `2.0#1` -> `2.0#2` - [(microsoft#23114)](microsoft#23114) [cereal] Update to 1.3.1 (by @mapret) - lazy-importer `2021-10-23#0` -> `2022-02-09#0` - [(microsoft#23192)](microsoft#23192) [lazy-importer] Update to 2022-02-09 (by @Thomas1664) - gstreamer `1.19.2#3` -> `1.19.2#4` - [(microsoft#23125)](microsoft#23125) [gstreamer] Support arm-windows and add features (by @JackBoosY) - charls `2.2.0#2` -> `2.3.4#0` - [(microsoft#23189)](microsoft#23189) [charls] Update to 2.3.4 (by @Thomas1664) - arrow `7.0.0#0` -> `7.0.0#1` - [(microsoft#23188)](microsoft#23188) [arrow] add plasma support for non Windows platforms (by @fran6co) - trantor `1.5.4#0` -> `1.5.5#0` - [(microsoft#23182)](microsoft#23182) [trantor] Update to 1.5.5 (by @an-tao) - capstone `4.0.2#2` -> `4.0.2#3` - [(microsoft#23122)](microsoft#23122) [capstone] Use static runtime if capstone wants to be statically linked (by @illera88) - gainput `1.0.0#4` -> `1.0.0#5` - [(microsoft#23219)](microsoft#23219) [gainput] Support Linux (by @JackBoosY) - cereal `1.3.0#1` -> `1.3.1#0` - [(microsoft#23114)](microsoft#23114) [cereal] Update to 1.3.1 (by @mapret) </details> <details> <summary>The following additional changes have been made to vcpkg's infrastructure:</summary> - [(microsoft#23045)](microsoft#23045) [vcpkg docs] Update ko_KR translation (by @jnooree) - [(microsoft#23181)](microsoft#23181) [vcpkg doc] Fixes typo in vcpkg_download_distfile.cmake (by @acd1034) </details> -- vcpkg team vcpkg@microsoft.com Thu, 24 February 00:29:57 -0800

Use static runtime if capstone wants to be statically linked

9b599de

This makes more sense than using the shared runtime if building a static version

github-actions bot requested changes Feb 16, 2022

View reviewed changes

Cheney-W assigned JonLiu1993 Feb 16, 2022

JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 16, 2022

JonLiu1993 added the requires:author-response label Feb 16, 2022

JonLiu1993 changed the title ~~Use static runtime if capstone wants to be statically linked~~ [capstone ] Use static runtime if capstone wants to be statically linked Feb 16, 2022

increase port-version

5e4cf0d

github-actions bot requested changes Feb 16, 2022

View reviewed changes

Update version database

4c562ea

github-actions bot approved these changes Feb 16, 2022

View reviewed changes

illera88 added 2 commits February 17, 2022 11:50

select CRT as new feature

7bf72d2

don't use upercase in feature name

299e7fa

github-actions bot requested changes Feb 17, 2022

View reviewed changes

illera88 added 2 commits February 17, 2022 12:02

format json

d403f62

run x-add-version

3708004

github-actions bot approved these changes Feb 17, 2022

View reviewed changes

JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed requires:author-response category:port-bug The issue is with a library, which is something the port should already support labels Feb 17, 2022

JonLiu1993 reviewed Feb 17, 2022

View reviewed changes

ports/capstone/portfile.cmake Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Feb 17, 2022

remove extra space

c90ee86

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot requested changes Feb 17, 2022

View reviewed changes

run x-add-version

51d5d42

github-actions bot approved these changes Feb 17, 2022

View reviewed changes

illera88 requested a review from JonLiu1993 February 17, 2022 06:33

JonLiu1993 removed the requires:author-response label Feb 17, 2022

Modernize the port file.cmake

f922dbd

JackBoosY changed the title ~~[capstone ] Use static runtime if capstone wants to be statically linked~~ [capstone] Use static runtime if capstone wants to be statically linked Feb 21, 2022

checking feature per OS

45d790d

github-actions bot requested changes Feb 21, 2022

View reviewed changes

update versioning

af19fec

github-actions bot approved these changes Feb 21, 2022

View reviewed changes

JonLiu1993 approved these changes Feb 21, 2022

View reviewed changes

JackBoosY suggested changes Feb 21, 2022

View reviewed changes

ports/capstone/portfile.cmake Outdated Show resolved Hide resolved

remove check for static CRT on windows so it doesn't conflict with ot…

b24c4e2

…her ports (Triton)

github-actions bot requested changes Feb 21, 2022

View reviewed changes

update versioning

b61afa6

github-actions bot approved these changes Feb 21, 2022

View reviewed changes

illera88 mentioned this pull request Feb 21, 2022

[New port] Add Triton port #23111

Merged

use VCPKG_CRT_LINKAGE instead of feature for CRT

de2f6bf

github-actions bot requested changes Feb 21, 2022

View reviewed changes

update versioning

9a52604

github-actions bot approved these changes Feb 21, 2022

View reviewed changes

illera88 requested a review from JackBoosY February 21, 2022 12:29

JackBoosY approved these changes Feb 22, 2022

View reviewed changes

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Feb 22, 2022

vicroms merged commit 7033f94 into microsoft:master Feb 22, 2022

BillyONeal mentioned this pull request Feb 24, 2022

[vcpkg] Add fixed changelog generator. #23255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[capstone] Use static runtime if capstone wants to be statically linked #23122

[capstone] Use static runtime if capstone wants to be statically linked #23122

illera88 commented Feb 16, 2022

github-actions bot left a comment

JonLiu1993 commented Feb 16, 2022

github-actions bot left a comment

illera88 commented Feb 16, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

illera88 commented Feb 21, 2022 •

edited

JackBoosY commented Feb 21, 2022

illera88 commented Feb 21, 2022

JonLiu1993 commented Feb 21, 2022

github-actions bot left a comment

github-actions bot left a comment

illera88 commented Feb 21, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

[capstone] Use static runtime if capstone wants to be statically linked #23122

[capstone] Use static runtime if capstone wants to be statically linked #23122

Conversation

illera88 commented Feb 16, 2022

Which triplets are supported/not supported? Have you updated the [CI baseline]

Does your PR follow the maintainer guide?

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Feb 16, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

illera88 commented Feb 16, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

illera88 commented Feb 21, 2022 • edited

JackBoosY commented Feb 21, 2022

illera88 commented Feb 21, 2022

JonLiu1993 commented Feb 21, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

illera88 commented Feb 21, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

illera88 commented Feb 21, 2022 •

edited