Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baseline] [python3] fix bz2(d) search on linux #23525

Merged
merged 4 commits into from
Mar 14, 2022
Merged

[baseline] [python3] fix bz2(d) search on linux #23525

merged 4 commits into from
Mar 14, 2022

Conversation

Neumann-A
Copy link
Contributor

  • bonus 1: disable test modules used to test python.
  • bonus 2; disable dependency on readline explicitly.

@Thomas1664 Thomas1664 mentioned this pull request Mar 13, 2022
Merged
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Mar 14, 2022
JackBoosY
JackBoosY approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this may be a upstream bug right?

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 14, 2022
@JackBoosY
Copy link
Contributor

Ping @vicroms for merge this PR quickly.

This was referenced Mar 14, 2022
Closed
Closed
Merged
Merged
Merged
@Neumann-A
Copy link
Contributor Author

So this may be a upstream bug right?

depends on how you view library naming shenanigans. Considering that vcpkg vendors a CMakeLists.txt for bzip2 I would disagree with that.

@Neumann-A Neumann-A mentioned this pull request Mar 14, 2022
Merged
@vicroms vicroms merged commit 9659615 into microsoft:master Mar 14, 2022
@Neumann-A Neumann-A deleted the fix_python3_readline branch March 14, 2022 08:16
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 14, 2022
@ekilmer
Merge branch 'master' into more-lief
cc8c5a7 
* master: (64 commits)
  [baseline] [python3] fix bz2(d) search on linux (microsoft#23525)
  [HPX] Don't remove HPXCacheVariables.cmake during install (microsoft#23042)
  [earcut.hpp] New port (microsoft#23507)
  [libssh2] Fix deleted configfiles (microsoft#23509)
  [python3] Update to Python 3.10.2. (microsoft#23156)
  [qt5-webengine] Fix apply patch failed (microsoft#23484)
  [llvm] Fix LLVM install for 'utils' feature (microsoft#23399)
  [sciter-js] Updated sciter-js to 4.4.8.31 (microsoft#23357)
  [GTL] Add new port (microsoft#23400)
  [raylib] Fix cannot find -lglfw on Linux (microsoft#23348)
  [yato] fix arm build by updating (microsoft#23406)
  [ois] fix pkgconfig file not installed on windows (microsoft#23426)
  Fix the dependency of installing arrow with the parquet feature (microsoft#23423)
  [libjpeg-turbo] Fix usage when building static (microsoft#23427)
  [sentencepiece] Clarify supported triplets (microsoft#23438)
  [zpp-bits] Add new port (microsoft#23458)
  [lionkor-commandline] Add new port (microsoft#23471)
  [libde265] fix static linkage (microsoft#23479)
  [libheif] fix license (microsoft#23480)
  [proj4] Retain former features (fixes `vcpkg upgrade`) (microsoft#23487)
  ...
@JackBoosY JackBoosY mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neumann-A @JackBoosY @vicroms