[vcpkg baseline][qtapplicationmanager] Configure hardcodes bin paths. #23638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
changed the title
JackBoosY
added
the
category:port-bug
JackBoosY
approved these changes
Mar 21, 2022
JackBoosY
changed the title
strega-nil
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
I've re-run CI at https://dev.azure.com/vcpkg/public/_build/results?buildId=69170&view=results, if someone wants to look at the build. This LGTM!
strega-nil-ms
force-pushed
the
fix_qtapplication_manager
branch
from
01df52e
to
2d34bd0
Compare
|
This looks good to me and I merged because the CI build linked was green |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Mar 22, 2022
PASSING, REMOVE FROM FAIL LIST: intelrdfpmathlib:x64-linux PASSING, REMOVE FROM FAIL LIST: ocilib:x64-windows-static PASSING, REMOVE FROM FAIL LIST: skia:arm64-windows PASSING, REMOVE FROM FAIL LIST: yato:x64-windows-static-md REGRESSION: argtable3:arm-uwp No repro. Maybe fixed by microsoft#23655 REGRESSION: infoware:x64-windows-static ``` -- Found Git: C:/agent/externals/git/cmd/git.exe (found version "2.30.2.windows.1") Cloning into 'pciids'... fatal: unable to access 'https://github.com/pciutils/pciids/': Could not resolve host: github.com CMake Error at CMakeLists.txt:111 (message): Cloning/pulling pciids repository from https://github.com/pciutils/pciids failed with 128. The pci.ids file, downloadable from https://github.com/pciutils/pciids or http://pci-ids.ucw.cz, is required for building infoware, and cloned automatically from that GitHub repository by default. To use a local copy, set INFOWARE_PCI_IDS_PATH to its location. ``` Looks like this port needs to be fixed to work with artifact caching. REGRESSION: libgpg-error:x64-uwp ``` "D:\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error.sln" (Rebuild target) (1) -> "D:\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error_winrt.vcxproj" (Rebuild target) (2) -> (_GetPackageFileExtensions target) -> C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Microsoft.AppXPackage.Targets(892,25): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformMinVersion)" that evaluates to "" instead of a number, in condition "'$(TargetPlatformMinVersion)' >= '10.0.17200.0'". [D:\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error_winrt.vcxproj] ``` This looks like a VS2022 regression. REGRESSION: chromium-base:x64-osx This port is still having the strange behavior where building it once fails but building it again succeeds O_O REGRESSION: libmikmod:x64-osx This is emitting a bunch of spew about standard library symbols. REGRESSION: qtapplicationmanager:x64-windows Should be fixed by microsoft#23638
BillyONeal
added a commit
that referenced
this pull request
Mar 22, 2022
PASSING, REMOVE FROM FAIL LIST: intelrdfpmathlib:x64-linux PASSING, REMOVE FROM FAIL LIST: ocilib:x64-windows-static PASSING, REMOVE FROM FAIL LIST: skia:arm64-windows PASSING, REMOVE FROM FAIL LIST: yato:x64-windows-static-md REGRESSION: argtable3:arm-uwp No repro. Maybe fixed by #23655 REGRESSION: infoware:x64-windows-static ``` -- Found Git: C:/agent/externals/git/cmd/git.exe (found version "2.30.2.windows.1") Cloning into 'pciids'... fatal: unable to access 'https://github.com/pciutils/pciids/': Could not resolve host: github.com CMake Error at CMakeLists.txt:111 (message): Cloning/pulling pciids repository from https://github.com/pciutils/pciids failed with 128. The pci.ids file, downloadable from https://github.com/pciutils/pciids or http://pci-ids.ucw.cz, is required for building infoware, and cloned automatically from that GitHub repository by default. To use a local copy, set INFOWARE_PCI_IDS_PATH to its location. ``` Looks like this port needs to be fixed to work with artifact caching. REGRESSION: libgpg-error:x64-uwp ``` "D:\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error.sln" (Rebuild target) (1) -> "D:\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error_winrt.vcxproj" (Rebuild target) (2) -> (_GetPackageFileExtensions target) -> C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Microsoft.AppXPackage.Targets(892,25): error MSB4086: A numeric comparison was attempted on "$(TargetPlatformMinVersion)" that evaluates to "" instead of a number, in condition "'$(TargetPlatformMinVersion)' >= '10.0.17200.0'". [D:\buildtrees\libgpg-error\x64-uwp-rel\error-1.42-2324ddbc71.clean\SMP\libgpg-error_winrt.vcxproj] ``` This looks like a VS2022 regression. REGRESSION: chromium-base:x64-osx This port is still having the strange behavior where building it once fails but building it again succeeds O_O REGRESSION: libmikmod:x64-osx This is emitting a bunch of spew about standard library symbols. REGRESSION: qtapplicationmanager:x64-windows Should be fixed by #23638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.