Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdatrie]Fix usage of FindPkgConfig module #23708

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 22, 2022

  • What does your PR fix?

    Make use of FindPkgConfig.cmake via find_package, not include.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@JonLiu1993 JonLiu1993 self-assigned this Mar 22, 2022
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 22, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Mar 22, 2022
@dan-shaw dan-shaw merged commit 9958c2c into microsoft:master Mar 23, 2022
@dg0yt dg0yt deleted the findpkgconfig branch March 23, 2022 06:55
@JonLiu1993 JonLiu1993 changed the title Fix usage of FindPkgConfig module [libdatrie]Fix usage of FindPkgConfig module Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants