[gtk3] Add new/old port gtk3 #24136

talregev · 2022-04-14T06:24:08Z

[gtk3] Add new/old port gtk3.

Please help me to make this port useable again. Thank you.

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gtk3/portfile.cmake

JackBoosY · 2022-04-14T09:26:52Z

Seems we already have a PR to add gtk3: #22201

talregev · 2022-04-14T09:33:42Z

Seems we already have a PR to add gtk3: #22201

Yes, but it have a lot of troubles, and it take a lot of time to merge. This old one already approve to master. I just try to revive it.
Also @dg0yt Tell me if I want to talk with "we", I should do it first.
So, @dg0yt you are welcome to help me as well.

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gtk3/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtk3 but no changes to version or port version.
-- Version: 3.22.19
-- Old SHA: 1a77ead339d62434a63556e816fe3b4dba3335f9
-- New SHA: ff4669afedbd57300cd96e2b4c8eb3867f005a8b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/gtk3/portfile.cmake

talregev · 2022-04-18T10:19:15Z

It not find the:
find_library(LIBINTL_LIBRARY
@dg0yt @JackBoosY Can you help?

talregev · 2022-04-18T13:17:59Z

I did as much as I can. I am not sure why the old port don't work out of the box.
Now there many linkage and compilation errors. At least it find all the libraries.

JackBoosY · 2022-04-18T14:56:40Z

Will handle this PR later.

…/gtk3

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtk3 but no changes to version or port version.
-- Version: 3.22.19
-- Old SHA: 6c253e1857e8042f489ca75da087a1e39292121a
-- New SHA: e7ddf51f8617899ae25e11f545a17e23308b7529
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

JackBoosY · 2022-04-19T09:00:56Z

Will handle the headers installation later.

ports/gtk3/CMakeLists.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtk3 but no changes to version or port version.
-- Version: 3.22.19
-- Old SHA: 8c1c2927050dc6b27970b312a4d1a4b38abaaaf9
-- New SHA: 13000431f9bd0843578086a2815706ec969deccf
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/gtk3/CMakeLists.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtk3 but no changes to version or port version.
-- Version: 3.22.19
-- Old SHA: 8c1c2927050dc6b27970b312a4d1a4b38abaaaf9
-- New SHA: fe1bf2d9a05e70fb4e2e1385a2988c3bea2e018a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtk3 but no changes to version or port version.
-- Version: 3.22.19
-- Old SHA: 8c1c2927050dc6b27970b312a4d1a4b38abaaaf9
-- New SHA: 365598e73f90ae0d4f28358c40c5db707d26a788
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

JackBoosY · 2022-04-19T10:16:49Z

The section about adding source files in CMakeLists.txt must be refactored to fully accommodate all systems.

talregev · 2022-04-19T17:03:10Z

The section about adding source files in CMakeLists.txt must be refactored to fully accommodate all systems.

Can you do that?

github-actions bot approved these changes Apr 14, 2022

View reviewed changes

JackBoosY self-assigned this Apr 14, 2022

JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 14, 2022

talregev force-pushed the TalR/gtk3 branch from 586950e to 6886db4 Compare April 18, 2022 08:04

github-actions bot approved these changes Apr 18, 2022

View reviewed changes

talregev force-pushed the TalR/gtk3 branch from 6886db4 to d35b03d Compare April 18, 2022 10:18

github-actions bot requested changes Apr 18, 2022

View reviewed changes

talregev force-pushed the TalR/gtk3 branch from d35b03d to 967dc61 Compare April 18, 2022 10:33

github-actions bot approved these changes Apr 18, 2022

View reviewed changes

Add gtk3

2563193

talregev force-pushed the TalR/gtk3 branch from 967dc61 to 2563193 Compare April 18, 2022 13:16

github-actions bot approved these changes Apr 18, 2022

View reviewed changes

JackBoosY added 2 commits April 19, 2022 00:57

Merge branch 'master' of https://github.com/microsoft/vcpkg into TalR…

d04a66a

…/gtk3

Fix build, refactor portfile.cmake

c97c181

github-actions bot requested changes Apr 19, 2022

View reviewed changes

Fix pango

5d0c94d

github-actions bot approved these changes Apr 19, 2022

View reviewed changes

JackBoosY reviewed Apr 19, 2022

View reviewed changes

ports/gtk3/CMakeLists.txt Outdated Show resolved Hide resolved

Update ports/gtk3/CMakeLists.txt

9755a62

github-actions bot requested changes Apr 19, 2022

View reviewed changes

talregev commented Apr 19, 2022

View reviewed changes

ports/gtk3/CMakeLists.txt Outdated Show resolved Hide resolved

JackBoosY reviewed Apr 19, 2022

View reviewed changes

ports/gtk3/CMakeLists.txt Outdated Show resolved Hide resolved

Update ports/gtk3/CMakeLists.txt

27e3661

github-actions bot requested changes Apr 19, 2022

View reviewed changes

Add WIN32 condition

71bfd97

github-actions bot requested changes Apr 19, 2022

View reviewed changes

talregev closed this May 3, 2022

talregev deleted the TalR/gtk3 branch May 7, 2022 05:42

mkhon mentioned this pull request Sep 28, 2022

[new port] gtk 3.24.34 port #22201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gtk3] Add new/old port gtk3 #24136

[gtk3] Add new/old port gtk3 #24136

talregev commented Apr 14, 2022

github-actions bot left a comment

JackBoosY commented Apr 14, 2022

talregev commented Apr 14, 2022

github-actions bot left a comment

github-actions bot left a comment

talregev commented Apr 18, 2022

talregev commented Apr 18, 2022

JackBoosY commented Apr 18, 2022

github-actions bot left a comment

JackBoosY commented Apr 19, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

JackBoosY commented Apr 19, 2022

talregev commented Apr 19, 2022

[gtk3] Add new/old port gtk3 #24136

[gtk3] Add new/old port gtk3 #24136

Conversation

talregev commented Apr 14, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Apr 14, 2022

talregev commented Apr 14, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

talregev commented Apr 18, 2022

talregev commented Apr 18, 2022

JackBoosY commented Apr 18, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Apr 19, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JackBoosY commented Apr 19, 2022

talregev commented Apr 19, 2022