[new port] gtk 3.24.34 port #22201

mkhon · 2021-12-25T20:10:15Z

New port: gtk 3.24.34 (some software still requires GTK3)

What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?

all

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

nlogozzo · 2021-12-26T04:46:11Z

Could we see a gtkmm3 port as well?

mkhon · 2021-12-26T10:00:15Z

Sure, I will work on gtk3mm port

nlogozzo · 2021-12-26T13:56:41Z

Cool, thanks :)

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for gtk3 but no changes to version or port version.
-- Version: 3.24.30
-- Old SHA: 8fcadeff3c2eba6e6cd20b1158014c8f308dea54
-- New SHA: 4fb3acb0474e205624b3a2b4c1f02a45468be19c
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

JonLiu1993 · 2021-12-27T06:12:43Z

@mkhon ,Thanks for your pr, for the x86-windows error, you can run command "./vcpkg x-add-version gtk3 --overwrite-version " and commit again after you finish your pr.

Found the following errors:
##[error]versions/g-/gtk3.json(2,): error : While reading versions for port gtk3 from file: version/g-/gtk3.json
File declares version `3.24.30` with SHA: 8fcadeff3c2eba6e6cd20b1158014c8f308dea54
But local port with the same version has a different SHA: 4fb3acb0474e205624b3a2b4c1f02a45468be19c
Please update the port's version fields and then run:

    vcpkg x-add-version gtk3
    git add versions
    git commit -m "Update version database"

to add a new version.

To attempt to resolve all errors at once, run:

    vcpkg x-add-version --all

##[error]PowerShell exited with code '1'.

and This is the detail error log please take a look:
https://dev.azure.com/vcpkg/public/_build/results?buildId=64967&view=artifacts&pathAsName=false&type=publishedArtifacts

JonLiu1993 · 2021-12-29T08:20:15Z

@mkhon , it looks the post build step failed.
See the CI failures:
https://dev.azure.com/vcpkg/public/_build/results?buildId=65027&view=artifacts&pathAsName=false&type=publishedArtifacts

JonLiu1993 · 2021-12-30T10:30:28Z

@mkhon ，It seems that the error has not been solved yet, here is the detailed error log
https://dev.azure.com/vcpkg/public/_build/results?buildId=65097&view=artifacts&pathAsName=false&type=publishedArtifacts

JonLiu1993 · 2022-01-05T06:51:16Z

@mkhon ,I encountered this error when verifying the feature, it seems that port pango does not have an introspection feature
./vcpkg install gtk3[*]:x64-windows

Package pango does not have a introspection feature

mkhon · 2022-01-05T09:55:33Z

@JonLiu1993 introspection feature is added in #22200

JonLiu1993 · 2022-01-05T11:22:23Z

Depends on pr #22200

talregev · 2022-06-05T08:47:40Z

I look again on wxwidgets and I faild to change that it take glib from vcpkg. ~~I think wxwidgets take the correct gtk3 (from vcpkg). and gtk3 doesn't publish the correct glib. (it publish system glib).~~
~/vcpkg/installed/x64-linux/lib/pkgconfig
> pkg-config gtk+-3.0.pc --libs
-L./../../lib -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -latk-1.0 -latk-bridge-2.0 -lepoxy -lfribidi -lpangoft2-1.0 -lpango-1.0 -lharfbuzz -lfontconfig -lfreetype -lgio-2.0 -lgobject-2.0 -lglib-2.0
~~Can you change that it will take from vcpkg and not from system?~~

Edit: I think the problem is on wxwidgets that I failed to fix.

I fix the gkt ld error I got. It was bug in our end (boinc opensource project).
I fix it on this PR:
BOINC/boinc#4756

ports/gtk3/0001-build.patch

JackBoosY · 2022-06-06T09:08:31Z

ports/gtk3/portfile.cmake

+set(warning_length 24)
+string(LENGTH "${CURRENT_BUILDTREES_DIR}" buildtrees_path_length)
+if(buildtrees_path_length GREATER warning_length AND CMAKE_HOST_WIN32)
+    message(WARNING "${PORT}'s buildsystem uses very long paths and may fail on your system.\n"
+        "We recommend moving vcpkg to a short path such as 'C:\\vcpkg' or using the subst command."
+    )
+endif()


Suggested change

set(warning_length 24)

string(LENGTH "${CURRENT_BUILDTREES_DIR}" buildtrees_path_length)

if(buildtrees_path_length GREATER warning_length AND CMAKE_HOST_WIN32)

message(WARNING "${PORT}'s buildsystem uses very long paths and may fail on your system.\n"

"We recommend moving vcpkg to a short path such as 'C:\\vcpkg' or using the subst command."

)

endif()

vcpkg_buildpath_length_warning(24)

vcpkg_buildpath_length_warning() can not be used here as it recommends to move to C:\src\vcpkg which gives buildpath length >24

So can you confirm a longest valid path to replace this code?

I tried subst and it seems not solving the problem. Moving to the root of a drive may be the only choice.

I would also suggest we make it clear that the path length cannot exceed 24 (if that’s the exact number). This message could fail to inform the user of what kind of paths are acceptable.

mkhon · 2022-06-07T11:01:58Z

@BillyONeal @dg0yt @mkhon There is a PR of dubs waiting, that why they will not rush and install dbus on the ci. That will hold at-spi2-atk port. The PR of dbus is open from January, and likely to be merge to the master in more then a few weeks. So the fastest way this PR can be merge to the master is to go with @dg0yt suggestion. Please:

Revert the at-spi2-atk bridge patch. The patch that cancel the use of the bridge in gtk3 and can compile again on linux.

Remove the skipped linux in the ci. Let the ci compile linux with success (after the patch).

Update with ./vcpkg x-add-version --all --overwrite-version

Then we can ask to review this PR again. hopefully it can be merge that way. In the meanwhile keep the at-spi2-atk PR. When dbus will be ready, we can merge it too, and fix gtk3 PR again, in separate PR.

I would like to hear from the maintainers, as we had this patch before and PR got rejected because of this.
I haven't heard from maintainers since then

JackBoosY · 2022-06-08T06:49:06Z

I'd like to wait for #24934 to add port at-spi2-atk first.

talregev · 2022-06-08T10:09:54Z

I'd like to wait for #24934 to add port at-spi2-atk first.

I would like that too! But vcpkg don't install dubs on the ci for that. 😢

- Use vcpkg_from_gitlab()

stevapple · 2022-08-22T23:19:22Z

ports/gtk3/portfile.cmake

+set(warning_length 24)
+string(LENGTH "${CURRENT_BUILDTREES_DIR}" buildtrees_path_length)
+if(buildtrees_path_length GREATER warning_length AND CMAKE_HOST_WIN32)
+    message(WARNING "${PORT}'s buildsystem uses very long paths and may fail on your system.\n"
+        "We recommend moving vcpkg to a short path such as 'C:\\vcpkg' or using the subst command."
+    )
+endif()


I tried subst and it seems not solving the problem. Moving to the root of a drive may be the only choice.

I would also suggest we make it clear that the path length cannot exceed 24 (if that’s the exact number). This message could fail to inform the user of what kind of paths are acceptable.

JonLiu1993 · 2022-09-02T09:57:59Z

Ping @mkhon for response.

JonLiu1993 · 2022-09-09T07:50:05Z

Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again.

JackBoosY · 2022-09-16T08:21:40Z

Waiting for #26766 merge first.
Before that, I think we should close this PR temporary. Then please ping me to reopen it.

talregev · 2022-09-16T09:11:47Z

Better that he will open this PR on his mkhon user.

mkhon · 2022-09-28T19:36:58Z

I opened a new PR #24136 for this

talregev · 2022-09-28T19:55:52Z

#24136 this is my PR. I can open it.

talregev · 2022-09-28T19:56:54Z

I think you meant this PR #27026

JackBoosY assigned JonLiu1993 Dec 26, 2021

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Dec 27, 2021

JonLiu1993 changed the title ~~gtk 3.24.30 port~~ [gtk] add new port Dec 27, 2021

JonLiu1993 changed the title ~~[gtk] add new port~~ [gtk] add new port gtk 3.24.30 Dec 27, 2021

JonLiu1993 changed the title ~~[gtk] add new port gtk 3.24.30~~ [gtk3] add new port Dec 27, 2021

github-actions bot requested changes Dec 27, 2021

View reviewed changes

JonLiu1993 added the requires:author-response label Dec 27, 2021

github-actions bot approved these changes Dec 29, 2021

View reviewed changes

github-actions bot approved these changes Dec 30, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Jan 4, 2022

github-actions bot approved these changes Jan 4, 2022

View reviewed changes

JonLiu1993 approved these changes Jan 4, 2022

View reviewed changes

JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jan 4, 2022

JonLiu1993 added the requires:author-response label Jan 5, 2022

JonLiu1993 added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Jan 5, 2022

mkhon changed the title ~~[gtk3] add new port~~ [new port] gtk 3.24.30 port Jan 6, 2022

github-actions bot approved these changes Jan 14, 2022

View reviewed changes

talregev mentioned this pull request Jun 5, 2022

[WIP] Add wxWidgets as manifest mode BOINC/boinc#4756

Closed

8 tasks

JackBoosY suggested changes Jun 6, 2022

View reviewed changes

JackBoosY added the requires:author-response label Jun 6, 2022

github-actions bot approved these changes Jun 6, 2022

View reviewed changes

talregev mentioned this pull request Jun 6, 2022

[dbus] install dubs on the ci. #25094

Closed

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 8, 2022

github-actions bot previously approved these changes Jun 9, 2022

View reviewed changes

ras0219-msft dismissed JonLiu1993’s stale review via 625a7ef June 23, 2022 19:58

mkhon and others added 3 commits June 24, 2022 13:20

gtk 3.24.30 port

b50866e

- Update to 3.24.33

b408bec

- Use vcpkg_from_gitlab()

Update to 3.24.34

74a40b7

mkhon dismissed github-actions’s stale review via 74a40b7 June 24, 2022 06:20

github-actions bot approved these changes Jun 24, 2022

View reviewed changes

JackBoosY removed the requires:author-response label Aug 19, 2022

stevapple suggested changes Aug 22, 2022

View reviewed changes

JonLiu1993 marked this pull request as draft September 9, 2022 07:50

JackBoosY closed this Sep 16, 2022

mkhon deleted the feature/gtk3 branch September 28, 2022 19:04

az0 mentioned this pull request Oct 1, 2022

Update Python 3 in Windows installer bleachbit/bleachbit#848

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[new port] gtk 3.24.34 port #22201

[new port] gtk 3.24.34 port #22201

mkhon commented Dec 25, 2021 •

edited

nlogozzo commented Dec 26, 2021

mkhon commented Dec 26, 2021

nlogozzo commented Dec 26, 2021

github-actions bot left a comment

JonLiu1993 commented Dec 27, 2021

JonLiu1993 commented Dec 29, 2021

JonLiu1993 commented Dec 30, 2021

JonLiu1993 commented Jan 5, 2022

mkhon commented Jan 5, 2022

JonLiu1993 commented Jan 5, 2022

talregev commented Jun 5, 2022

JackBoosY Jun 6, 2022

mkhon Jun 6, 2022

JackBoosY Jun 8, 2022

stevapple Aug 22, 2022 •

edited

mkhon commented Jun 7, 2022

JackBoosY commented Jun 8, 2022

talregev commented Jun 8, 2022

stevapple Aug 22, 2022 •

edited

JonLiu1993 commented Sep 2, 2022

JonLiu1993 commented Sep 9, 2022

JackBoosY commented Sep 16, 2022

talregev commented Sep 16, 2022

mkhon commented Sep 28, 2022

talregev commented Sep 28, 2022

talregev commented Sep 28, 2022

[new port] gtk 3.24.34 port #22201

[new port] gtk 3.24.34 port #22201

Conversation

mkhon commented Dec 25, 2021 • edited

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

nlogozzo commented Dec 26, 2021

mkhon commented Dec 26, 2021

nlogozzo commented Dec 26, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Dec 27, 2021

JonLiu1993 commented Dec 29, 2021

JonLiu1993 commented Dec 30, 2021

JonLiu1993 commented Jan 5, 2022

mkhon commented Jan 5, 2022

JonLiu1993 commented Jan 5, 2022

talregev commented Jun 5, 2022

JackBoosY Jun 6, 2022

Choose a reason for hiding this comment

mkhon Jun 6, 2022

Choose a reason for hiding this comment

JackBoosY Jun 8, 2022

Choose a reason for hiding this comment

stevapple Aug 22, 2022 • edited

Choose a reason for hiding this comment

mkhon commented Jun 7, 2022

JackBoosY commented Jun 8, 2022

talregev commented Jun 8, 2022

stevapple Aug 22, 2022 • edited

Choose a reason for hiding this comment

JonLiu1993 commented Sep 2, 2022

JonLiu1993 commented Sep 9, 2022

JackBoosY commented Sep 16, 2022

talregev commented Sep 16, 2022

mkhon commented Sep 28, 2022

talregev commented Sep 28, 2022

talregev commented Sep 28, 2022

mkhon commented Dec 25, 2021 •

edited

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

stevapple Aug 22, 2022 •

edited

stevapple Aug 22, 2022 •

edited