Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Folly] add vcpkg_cmake_wrapper.cmake #24471

Merged
merged 8 commits into from
Jul 14, 2022

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 29, 2022
@ghost
Copy link

ghost commented Apr 29, 2022

CLA assistant check
All CLA requirements met.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for folly but no changes to version or port version.
-- Version: 2022.03.21.00#1
-- Old SHA: 44273a642b49021252e9d33f0c7934b4718b92e7
-- New SHA: ed4090ee43e85f5eb9a9946d460b07d080d0b5fe
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@FrankXie05 FrankXie05 changed the title Dev/frank/24064 [Folly] vcpkg_cmake_wrapper.cmake Apr 29, 2022
@FrankXie05 FrankXie05 changed the title [Folly] vcpkg_cmake_wrapper.cmake [Folly] add vcpkg_cmake_wrapper.cmake Apr 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Apr 29, 2022
@FrankXie05
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FrankXie05
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for folly have changed but the version was not updated
version: 2022.03.21.00#1
old SHA: c1b11303819bf16b4cde18fdc8e6511b7bb34ed7
new SHA: 4c3aa6d1d1d4b52926fa4783fba5bab178472680
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@FrankXie05 FrankXie05 marked this pull request as ready for review June 24, 2022 10:10
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 14, 2022
@vicroms vicroms merged commit 8b62d95 into microsoft:master Jul 14, 2022
@FrankXie05 FrankXie05 deleted the dev/Frank/24064 branch July 15, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[folly] Build error when libunwind-dev system package is present in host environment
4 participants