Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atk,gdk-pixbuf,glib] Use vcpkg_from_gitlab. #24541

Merged
merged 3 commits into from
May 6, 2022

Conversation

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels May 5, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/atk/vcpkg.json
  • ports/gdk-pixbuf/vcpkg.json
  • ports/glib/vcpkg.json

Valid values for the license field can be found in the documentation

@talregev
Copy link
Contributor

talregev commented May 5, 2022

Sorry, I didn't know that I should do it like that.
Thank you for let me know!

@LilyWangLL
Copy link
Contributor

Hi, Billy, could you add "" for the path when installing copyright in portfile.cmake? And add license for these ports.

@BillyONeal
Copy link
Member Author

Hi, Billy, could you add "" for the path when installing copyright in portfile.cmake? And add license for these ports.

Done!

@BillyONeal
Copy link
Member Author

Sorry, I didn't know that I should do it like that.

Nothing to be sorry about! I missed it too!

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2022
@BillyONeal BillyONeal merged commit 309f985 into microsoft:master May 6, 2022
@BillyONeal BillyONeal deleted the gnome-gitlab branch May 6, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants