Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis-plus-plus] Add feature async-std and fix dependency libuv #25272

Merged
merged 7 commits into from
Jun 17, 2022

Conversation

JackBoosY
Copy link
Contributor

Fixes #25248.

Already tested this feature on x86-windows and x64-windows-static.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Jun 16, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/redis-plus-plus/vcpkg.json

Valid values for the license field can be found in the documentation

@JackBoosY JackBoosY requested a review from Cheney-W June 16, 2022 09:46
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 16, 2022
@elmanelman
Copy link

@JackBoosY @Cheney-W
pls take a look before merging #25248 (comment)

@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Jun 17, 2022
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 17, 2022
@dan-shaw dan-shaw merged commit 945e171 into microsoft:master Jun 17, 2022
@JackBoosY JackBoosY deleted the dev/jack/25248 branch June 20, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[redis-plus-plus] Support async interface with features
4 participants