-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[redis-plus-plus] Support async interface with features #25248
Comments
According to our policy, we refuse to accept adding conflicting features. So do you need |
It would be nice to set I suggest adding two features (meanwhile, I will be glad of better solutions):
So, you could pick |
Which boost components is required by |
@elmanelman According to our doc, we can only pick one feature, |
Hmm, I got it and think we can leave But what is the right way to give a choice between |
If you need to use |
Awesome, thanks! |
Is your feature request related to a problem? Please describe.
For now it isn't possible to choose whether to install and build async part of redis-plus-plus with vcpkg. These features are enabled with cmake variables:
REDIS_PLUS_PLUS_BUILD_ASYNC=libuv
and, optionally,REDIS_PLUS_PLUS_ASYNC_FUTURE=boost
, if you want to useboost::future
instead ofstd::future
.Proposed solution
Add library features that, being selected, will set
...BUILD_ASYNC
and...ASYNC_FUTURE
variables.For instance,
redis-plus-plus[async]
(or[async-std]
) could set...BUILD_ASYNC=libuv
only, andredis-plus-plus[async-boost]
could set both...BUILD_ASYNC=libuv
and...ASYNC_FUTURE=boost
.Describe alternatives you've considered
I couldn't find any other concise ways to solve this.
The text was updated successfully, but these errors were encountered: