-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tidy-html5] Update to 5.8.0, dynamic linkage, unique link lib name #25478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankXie05
added
the
category:port-update
The issue is with a library, which is requesting update new revision
label
Jun 30, 2022
I will update this PR when #24935 is merged. |
FrankXie05
added
the
depends:different-pr
This PR or Issue depends on a PR which has been filed
label
Jun 30, 2022
LilyWangLL
reviewed
Jul 7, 2022
LilyWangLL
removed
the
depends:different-pr
This PR or Issue depends on a PR which has been filed
label
Jul 7, 2022
LilyWangLL
previously approved these changes
Jul 7, 2022
FrankXie05
previously approved these changes
Jul 7, 2022
Thomas1664
reviewed
Jul 7, 2022
dg0yt
dismissed stale reviews from FrankXie05, LilyWangLL, and GitHub Actions
via
July 7, 2022 11:11
c0cc552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Updates tidy-html5 to the latest stable version.
Disables doc, removing the libxslt dependency.
Enables building with dynamic linkage.
Drop
_static
suffix from the static lib name for Windows, to match the dynamic import lib name. (Disruptive for existing users now, but actually necessary to allow consuming with variable linkage, and to match the pc file.)Fix debug postfix in pc file.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes. (NB: "Static and shared variants often should be renamed to a common scheme.")
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes.