Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy-html5] Update to 5.8.0, dynamic linkage, unique link lib name #25478

Merged
merged 8 commits into from
Jul 7, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jun 29, 2022

  • What does your PR fix?

    Updates tidy-html5 to the latest stable version.
    Disables doc, removing the libxslt dependency.
    Enables building with dynamic linkage.
    Drop _static suffix from the static lib name for Windows, to match the dynamic import lib name. (Disruptive for existing users now, but actually necessary to allow consuming with variable linkage, and to match the pc file.)
    Fix debug postfix in pc file.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes. (NB: "Static and shared variants often should be renamed to a common scheme.")

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes.

@dg0yt dg0yt marked this pull request as draft June 29, 2022 15:50
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2022
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 30, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Jun 30, 2022

I will update this PR when #24935 is merged.

@FrankXie05 FrankXie05 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 30, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 7, 2022
@dg0yt dg0yt marked this pull request as ready for review July 7, 2022 03:09
@LilyWangLL LilyWangLL removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 7, 2022
LilyWangLL
LilyWangLL previously approved these changes Jul 7, 2022
FrankXie05
FrankXie05 previously approved these changes Jul 7, 2022
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jul 7, 2022
@dg0yt dg0yt dismissed stale reviews from FrankXie05, LilyWangLL, and GitHub Actions via c0cc552 July 7, 2022 11:11
@vicroms vicroms merged commit b01fbe8 into microsoft:master Jul 7, 2022
@dg0yt dg0yt deleted the tidy-html5 branch July 8, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants