Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][opencensus-cpp] Set cxx standard to 14 for compatibility with abseil #25735

Merged
merged 6 commits into from
Jul 12, 2022

Conversation

Thomas1664
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes build error because this port depends on abseil which requires C++ 14:
FAILED: _deps/abseil-build/absl/base/CMakeFiles/absl_base.dir/internal/unscaledcycleclock.cc.o 
/usr/bin/c++  -I/mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src -fPIC -g -Wall -Wextra -Wcast-qual -Wconversion-null -Wformat-security -Wmissing-declarations -Woverlength-strings -Wpointer-arith -Wundef -Wunused-local-typedefs -Wunused-result -Wvarargs -Wvla -Wwrite-strings -DNOMINMAX -std=gnu++11 -MD -MT _deps/abseil-build/absl/base/CMakeFiles/absl_base.dir/internal/unscaledcycleclock.cc.o -MF _deps/abseil-build/absl/base/CMakeFiles/absl_base.dir/internal/unscaledcycleclock.cc.o.d -o _deps/abseil-build/absl/base/CMakeFiles/absl_base.dir/internal/unscaledcycleclock.cc.o -c /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/internal/unscaledcycleclock.cc
In file included from /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/config.h:86,
                 from /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/attributes.h:37,
                 from /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/port.h:21,
                 from /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/internal/unscaledcycleclock.h:45,
                 from /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/internal/unscaledcycleclock.cc:15:
/mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported."
   79 | #error "C++ versions less than C++14 are not supported."
      |  ^~~~~
[2/187] /usr/bin/c++  -I/mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src -fPIC -g -Wall -Wextra -Wcast-qual -Wconversion-null -Wformat-security -Wmissing-declarations -Woverlength-strings -Wpointer-arith -Wundef -Wunused-local-typedefs -Wunused-result -Wvarargs -Wvla -Wwrite-strings -DNOMINMAX -std=gnu++11 -MD -MT _deps/abseil-build/absl/strings/CMakeFiles/absl_strings_internal.dir/internal/utf8.cc.o -MF _deps/abseil-build/absl/strings/CMakeFiles/absl_strings_internal.dir/internal/utf8.cc.o.d -o _deps/abseil-build/absl/strings/CMakeFiles/absl_strings_internal.dir/internal/utf8.cc.o -c /mnt/vcpkg-ci/buildtrees/opencensus-cpp/x64-linux-dbg/_deps/abseil-src/absl/strings/internal/utf8.cc
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Remove Windows from CI baseline (covered by supports)

github-actions[bot]
github-actions bot previously approved these changes Jul 12, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opencensus-cpp/vcpkg.json

Valid values for the license field can be found in the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants