-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[osgearth] Fix errors that occur in the osgearth config file on some platforms #26024
Conversation
Local testing in progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM with the one suggestion applied.
versions/o-/osgearth.json#L2
to add a new version. |
Please don't change
|
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sorry about that. I amended the modification with the proper port version. |
Thanks! |
Describe the pull request
What does your PR fix?
Fixes the exported target in osgEarthConfig.cmake. Though it seems to work on Windows, on other platforms (e.g. Linux) the capitalization of the
find_path
argument causes the operation to fail, and the lack of the library definition causes an error upon attempting to set that target's properties.Which triplets are supported/not supported? Have you updated the CI baseline?
Unchanged
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes