[osgearth] Fix naming of target and exported variables #26258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for osgearth have changed but the version was not updated
version: 3.3#2
old SHA: 6f1f5c8fd268a733ce4774fcc79a6d71d9a6a003
new SHA: 5a9e3fa28dc78e768ff9ef2ca4ff09b51b774cbb
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
JackBoosY
added
the
category:port-bug
|
"Please check with the author of.... Oh wait. :)" Thanks! |
diegovelaz
added a commit
to diegovelaz/vcpkg
that referenced
this pull request
Aug 10, 2022
Format and add version. Update CI baseline. Update port version. [vcpkg] Fix cross compiling macOS (microsoft#26240) This follows the pattern in the Windows toolchain with respect to setting VCPKG_CMAKE_SYSTEM_VERSION and also how arm64 macOS can execute x86_64 through Rosetta. [buck-yeh-bux] fix clang-cl builds (microsoft#26248) * [buck-yeh-bux] fix clang-cl * v db [cppcms] Fix narrowing for clang-cl builds (microsoft#26251) * [cppcms] fix narrowing error with clang-cl * v db [crc32c] Clang-cl fix (microsoft#26253) * [crc32c] fix clang-cl builds. * v db [json-c] clang-cl fix. (microsoft#26254) * [json-c] fix clang-cl builds * v db [cpr] disable werror (microsoft#26252) * [cpr] disable werror * v db [sqlcipher] update to 4.5.2 (microsoft#26262) * [sqlcipher] update to 4.5.2 * requested changes * portfile.cmake - quote paths [osgearth] Fix naming of target and exported variables (microsoft#26258) * [osgearth] Fix target name and match exported variables * Fix version SHA Add port version to baseline. Add x64-linux build expected to fail. Add port 0 version. Update version database Specify supported CI so it only build dynamic. Update SHA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fixes some errors with the osgEarth CMake config introduced in #26024.
What does your PR fix?
The change to the target name suggested in [osgearth] Fix errors that occur in the osgearth config file on some platforms #26024 (comment) only covered that single usage of the target. It needs to be followed up by changing the exported variables and the call to
set_target_propertiesto match the new target name.Which triplets are supported/not supported? Have you updated the CI baseline?
All, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes