Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdatachannel] chore(version): updated to 0.17.9 #26141

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

crisboarna
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Updating libdatachannel version.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes, getting

./vcpkg x-add-version libdatachannel --overwrite-version                                           
/Users/runner/work/1/s/src/vcpkg.cpp(81): current_path("/Users/cris/vcpkg"): No such file or directory

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libdatachannel have changed but the version was not updated
version: 0.17.9
old SHA: 0770e9b271c6d1eb630a403f754c2dd2ee93f1c6
new SHA: d53db3b3973db56a095ed6aa9c6f5ee2c6eeb409
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Aug 3, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libdatachannel have changed but the version was not updated
version: 0.17.9
old SHA: d53db3b3973db56a095ed6aa9c6f5ee2c6eeb409
new SHA: 91ca5987e29fac6963c6ee8d6c4f91ecb621dd81
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Aug 3, 2022
@JackBoosY JackBoosY added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Aug 3, 2022
@JackBoosY
Copy link
Contributor

All features are tested successfully on x86-windows and x64-windows-static.

@JavierMatosD JavierMatosD merged commit 48f5177 into microsoft:master Aug 3, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

@crisboarna crisboarna deleted the feat/libdatachannel-bump branch September 1, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants