Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree-sitter] Remove the invalid records #26224

Merged
merged 1 commit into from
Aug 8, 2022
Merged

[tree-sitter] Remove the invalid records #26224

merged 1 commit into from
Aug 8, 2022

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Aug 8, 2022

Describe the pull request

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 8, 2022
@Cheney-W Cheney-W marked this pull request as ready for review August 8, 2022 06:23
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 8, 2022
kylo252
kylo252 reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that the CI should've caught this pass in the first, as it feels it's the point of using port-versions.

@Cheney-W
Copy link
Contributor Author

Cheney-W commented Aug 8, 2022

Thank you for your comment, bug CI can't do this at the moment, it may be implemented in the future.

@BillyONeal
Copy link
Member

Normally the version database is append only but this version was there for less than 1 business day. After confirmation with @ras0219 / @ras0219-msft and @vicroms we're going to do as this PR requests and yank.

Thanks @Cheney-W!

@BillyONeal BillyONeal merged commit 137dd8e into microsoft:master Aug 8, 2022
@Cheney-W Cheney-W deleted the Dev/Cheney/tree-sitter branch August 30, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylo252 kylo252 kylo252 left review comments

@github-actions github-actions[bot] github-actions approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cheney-W @BillyONeal @kylo252 @LilyWangLL