[tree-sitter] fix typo in version number #26209
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| "git-tree": "a912cc848f08c05d9cbd87e24e47194b0ad43bd6", | ||
| "version-semver": "0.26.0", |
There was a problem hiding this comment.
delete the old incorrect entry ?
I mean the port was only recently added so nobody should depend on it yet.
There was a problem hiding this comment.
I wasn't sure if this is allowed. I can try to push it and see if the CI complains.
There was a problem hiding this comment.
CI won't complain. I would just say removing it is justified since it will break version 0.26.0 in the future and isn't even what it wants to advertise.
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "name": "tree-sitter", | |||
| "version-semver": "0.26.0", | |||
| "version-semver": "0.20.6", | |||
There was a problem hiding this comment.
wasn't it to always use version instead of version-semver?
There was a problem hiding this comment.
wasn't it to always use
versioninstead ofversion-semver?
According to the manifest guide, version-semver may be used if upstream follows SemVer. Otherwise one should use version instead.
There was a problem hiding this comment.
ironically, I broke the semver with this PR, so it might make sense in this case to switch it to a version?
There was a problem hiding this comment.
According to the https://github.com/zeromq/azmq, version-semver may be used if upstream follows SemVer. Otherwise one should use version instead.
Your link is totally wrong. Qt also just uses version instead of version-semver and it was actively switched to use version instead.
There was a problem hiding this comment.
Your link is totally wrong.
Sorry. I updated the link.
There was a problem hiding this comment.
ironically, I broke the semver with this PR, so it might make sense in this case to switch it to a version?
The issue is that the version number can just increase. I'm not sure though what the correct solution is: either revert the PR that introduced the port or overwriting the old version.
IMO it's up to you. If yo are sure upstream follows SemVer, use version-semver. However, it is not necessarry to switch to version in order to get this merged (at least IMO).
There was a problem hiding this comment.
If upstream follows semver then I think it's good to leave it claiming version-semver. We had a pass where we were recommending people remove it because we had lots of changes to version-semver just because it met the semver regex without actually checking that upstream followed the semantic meaning.
I merged this as is to limit the potential 'damage' to less than 1 business day. Thanks for noticing and sorry that I didn't notice in my review 😅
Cheney-W
added
the
category:port-bug
Describe the pull request
What does your PR fix?
Fixes a typo in the version-number, see [tree-sitter] add new port #26058 (comment)
Which triplets are supported/not supported? Have you updated the CI baseline?
NA
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes