Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][nghttp3] Fix configure when cunit was installed #26604

Merged
merged 2 commits into from
Aug 31, 2022
Merged

[vcpkg baseline][nghttp3] Fix configure when cunit was installed #26604

merged 2 commits into from
Aug 31, 2022

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Aug 31, 2022 •
edited
Loading

When CUnit was installed and found, nghttp3 will enable static build:

...
if(HAVE_CUNIT OR ENABLE_STATIC_LIB)
  # Static library (for unittests because of symbol visibility)
  add_library(nghttp3_static STATIC ${nghttp3_SOURCES})
...

Fix this and disable testing.

Related: https://dev.azure.com/vcpkg/public/_build/results?buildId=77177&view=results&j=878666d5-db33-5b27-9e7d-b0c7ee352005

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Aug 31, 2022
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Aug 31, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

@JavierMatosD JavierMatosD merged commit c96b24c into microsoft:master Aug 31, 2022
@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20220830 branch September 1, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

@github-actions GitHub Actions GitHub Actions approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @JavierMatosD @Cheney-W