Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk 3.24.34 port #27026

Merged
merged 1 commit into from
Oct 3, 2022
Merged

gtk 3.24.34 port #27026

merged 1 commit into from
Oct 3, 2022

Conversation

mkhon
Copy link
Contributor

@mkhon mkhon commented Sep 28, 2022

Describe the pull request

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Sep 28, 2022
@talregev
Copy link
Contributor

This PR hold the latest master?

@talregev
Copy link
Contributor

@dg0yt @JackBoosY Can you help?

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 29, 2022
@JackBoosY
Copy link
Contributor

JackBoosY commented Sep 29, 2022

Run-time dependency atk-bridge-2.0 found: NO (tried pkgconfig and cmake)

../src/3.24.34-35fefc5b4d.clean/meson.build:585:2: ERROR: Dependency "atk-bridge-2.0" not found, tried pkgconfig and cmake
Determining dependency 'atk-bridge-2.0' with pkg-config executable '/bin/pkg-config'
env[PKG_CONFIG]: /bin/pkg-config
env[PKG_CONFIG_PATH]: /mnt/vcpkg-ci/installed/x64-linux/debug/lib/pkgconfig/:/mnt/vcpkg-ci/installed/x64-linux/debug/share/pkgconfig/
Called `/bin/pkg-config --modversion atk-bridge-2.0` -> 1

CMake binary for 1 is cached.
Preliminary CMake check failed. Aborting.
Run-time dependency atk-bridge-2.0 found: NO (tried pkgconfig and cmake)

../src/3.24.34-35fefc5b4d.clean/meson.build:585:2: ERROR: Dependency "atk-bridge-2.0" not found, tried pkgconfig and cmake

There only have installed/x64-linux/lib/pkgconfig/atk.pc, not atk-bridge-2.0.pc.

@talregev
Copy link
Contributor

talregev commented Sep 29, 2022

@JackBoosY We should add at-spi2-atk port to the dependencies. Can you do it?

@talregev
Copy link
Contributor

@mkhon Can you add at-spi2-atk port to the dependencies?

@talregev
Copy link
Contributor

talregev commented Sep 29, 2022

@JackBoosY Please review again. Thank you!

ports/gtk3/0001-build.patch Show resolved Hide resolved
ports/gtk3/portfile.cmake Show resolved Hide resolved
ports/gtk3/portfile.cmake Show resolved Hide resolved
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 30, 2022
@stevapple
Copy link

Is it ready for merge now?👀 Gtk3 is a long awaited port and many OSS projects could benefit from it🎉

Thank you for all the work!

@vicroms vicroms merged commit 8709c33 into microsoft:master Oct 3, 2022
@mkhon mkhon deleted the feature/gtk3 branch October 3, 2022 16:14
@dg0yt dg0yt mentioned this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants