Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gstreamer] enable builds on more platforms #27050

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

Neumann-A
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Sep 30, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gst-rtsp-server/vcpkg.json

Valid values for the license field can be found in the documentation

"description": "GStreamer open-source multimedia framework core library",
"homepage": "https://gstreamer.freedesktop.org/",
"license": "LGPL-2.0-only",
"supports": "!linux & !uwp",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this even !linux? This is a prime example how supports shouldn't be used.

@Neumann-A Neumann-A changed the title [gstreamer] enable static builds [gstreamer] enable builds on more platforms Sep 30, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 30, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gst-rtsp-server/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/gst-rtsp-server/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A Neumann-A marked this pull request as ready for review September 30, 2022 13:59
@vicroms vicroms merged commit 779ce74 into microsoft:master Oct 3, 2022
@Neumann-A Neumann-A deleted the fix_gstreamer_stuff branch October 3, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants