[liblsquic] Remove spurious duplicated install line. #27088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for liblsquic have changed but the version was not updated
version: 3.1.1
old SHA: f6f4593aba81acc749f3223d0fd3987d5920b164
new SHA: c0465f5427563597f522463086be8cddb8c7bba0
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Got left behind when the new helper usage was added before merging the original PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got left behind when the new helper usage was added before merging the original PR
What does your PR fix?
Fixing installing the liblsquic port, which I believe doesn't get tested by CI because it needs boringssl.
Which triplets are supported/not supported? Have you updated the CI baseline?
Tested on Linux, but should apply equally on all platforms.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes. Fixed what the bot wanted fixed too.