Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[avro-cpp] Update to latest version (2022-11-07) #27825

Merged
merged 13 commits into from
Nov 21, 2022

Conversation

PavelKisliak
Copy link
Contributor

@PavelKisliak PavelKisliak commented Nov 15, 2022

Update 'avro-cpp' port to latest version 1.11.2 pre-release

  • What does your PR fix?

    • Update avro-cpp to new version
    • Remove setting DEBUG option 'AVRO_ADD_PROTECTOR_FLAGS' (leading to binary incompatibility and segfault crashes)
    • Add feature for build tests
    • Remove not used dependencies
    • Update deprecated VCPKG functions
    • Add 'usage' file
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All (only with shared linkage), No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/avro-cpp/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/avro-cpp/vcpkg.json

Valid values for the license field can be found in the documentation

@PavelKisliak PavelKisliak marked this pull request as ready for review November 15, 2022 08:30
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 16, 2022
Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for avro-cpp have changed but the version was not updated
version: 1.11.1#1
old SHA: 4917161c9fa736b3fb13e732d23b31b6281f4c82
new SHA: 467b66abde73ece938b99e42a1ee8c5c389d5067
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/avro-cpp/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for avro-cpp have changed but the version was not updated
version: 1.11.1#1
old SHA: 4917161c9fa736b3fb13e732d23b31b6281f4c82
new SHA: 3b3bf8c46ba39c7f5b8cb1269437ac1cc3377d20
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/avro-cpp/portfile.cmake

github-actions[bot]
github-actions bot previously approved these changes Nov 16, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/avro-cpp/portfile.cmake

@PavelKisliak PavelKisliak marked this pull request as draft November 16, 2022 06:36
github-actions[bot]
github-actions bot previously approved these changes Nov 16, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/avro-cpp/portfile.cmake

@PavelKisliak
Copy link
Contributor Author

PavelKisliak commented Nov 16, 2022

Just wondering why there is still warning 'You have modified or added at least one portfile where deprecated functions are used.', I don't see any more deprecated functions from the list.

@PavelKisliak PavelKisliak marked this pull request as ready for review November 16, 2022 12:35
@MonicaLiu0311
Copy link
Contributor

Just wondering why there is still warning 'You have modified or added at least one portfile where deprecated functions are used.', I don't see any more deprecated functions from the list.

It may be this copyright function, and it will be changed next time.
file(INSTALL "${SOURCE_PATH}/lang/c++/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright)
New functions:
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/lang/c++/LICENSE")

@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:
x86-windows
x64-windows

MonicaLiu0311
MonicaLiu0311 previously approved these changes Nov 18, 2022
@MonicaLiu0311 MonicaLiu0311 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Nov 18, 2022
github-actions[bot]
github-actions bot previously approved these changes Nov 18, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for avro-cpp have changed but the version was not updated
version: 2022-11-07
old SHA: 74c8dbdb975f7a9b5ea80005345e604c89010d39
new SHA: 59a91b019e14de308c9d0857f863912cb5823962
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for avro-cpp have changed but the version was not updated
version: 2022-11-07
old SHA: 59a91b019e14de308c9d0857f863912cb5823962
new SHA: 08f82323ee0bb00a297cc1318c04dd3bce5d963e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@PavelKisliak PavelKisliak requested review from MonicaLiu0311 and dg0yt and removed request for MonicaLiu0311 and dg0yt November 18, 2022 11:22
@PavelKisliak PavelKisliak changed the title [avro-cpp] Update to 1.11.1 [avro-cpp] Update to latest version (2022-11-07) Nov 18, 2022
],
"features": {
"snappy": {
"description": "Support Snappy for compression",
"dependencies": [
"snappy"
]
},
"test": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this feature should exist: vcpkg should not be building tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just following official maintainer-guide, this is an optinal feature which is not build by default. I see that there are already existing a lot of ports with such feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal IMO the recommendation needs to be "optional feature", not "this feature shouldn't exist". Given a broad usage of vcpkg ports beyond platforms tested by upstream or vcpkg CI, the lack of an easy way to run tests on demand is a disservice for users.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 21, 2022
@JavierMatosD
Copy link
Contributor

Thank you

@JavierMatosD JavierMatosD merged commit 7432ae0 into microsoft:master Nov 21, 2022
lukaszmoroz pushed a commit to lukaszmoroz/vcpkg that referenced this pull request Nov 24, 2022
* [avro-cpp] Update to 1.11.1

* [avro-cpp] Update version file

* [Avro-cpp] Add "licence" to port file

Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>

* [Avro-cpp] Fix HEAD_REF branch (revert to master)

* [avro-cpp] Update version file

* [avro-cpp] Fix build 'test' feature, update version

* [avro-cpp] Update version

* [avro-cpp] Update 'usage' file and replace deprecated function

* [avro-cpp] Update version

* [avro-cpp] Update 'usage' file

* [avro-cpp] Update version

* [avro-cpp] Update 'usage' file

* [avro-cpp] Update version

Co-authored-by: MonicaLiu <110024546+MonicaLiu0311@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants