Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqlite3] Re-set option SQLITE_ENABLE_COLUMN_METADATA to 1 #27969

Merged
merged 2 commits into from
Nov 28, 2022
Merged

[sqlite3] Re-set option SQLITE_ENABLE_COLUMN_METADATA to 1 #27969

merged 2 commits into from
Nov 28, 2022

Conversation

FrankXie05
Copy link
Contributor

Describe the pull request

@FrankXie05 FrankXie05 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Nov 23, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Nov 23, 2022

Would it makes sense to burn the defines into the installed main include file?
It seems that they should be present regardless of how sqlite is used.

@FrankXie05
Copy link
Contributor Author

This option SQLITE_ENABLE_COLUMN_METADATA only provides additional APIs in C-preprocessor macro, Maybe I should pass in CLAGS.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 23, 2022

I see, the header always declares these functions, but the lib doesn't always provide implementations.

(I dislike vcpkg-vendored build systems.)

@FrankXie05 FrankXie05 marked this pull request as ready for review November 25, 2022 02:52
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Nov 25, 2022
@JavierMatosD
Copy link
Contributor

Thank you

@JavierMatosD JavierMatosD merged commit 481ff85 into microsoft:master Nov 28, 2022
@FrankXie05 FrankXie05 deleted the dev/Frank/27923 branch November 29, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sqlite3] PKGCONFIG_DEFINES & SQLITE_ENABLE_COLUMN_METADATA
4 participants
@FrankXie05 @dg0yt @JavierMatosD @Adela0814