Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[llhttp] add new port #28042

Merged
merged 8 commits into from
Nov 30, 2022
Merged

[llhttp] add new port #28042

merged 8 commits into from
Nov 30, 2022

Conversation

zynfly
Copy link
Contributor

@zynfly zynfly commented Nov 28, 2022 •
edited
Loading

add new port llhttp.

  • What does your PR fix?

    llhttp

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All. Yes.

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

@zynfly
Copy link
Contributor Author

zynfly commented Nov 28, 2022

@microsoft-github-policy-service agree

@zynfly zynfly closed this Nov 28, 2022
@zynfly zynfly reopened this Nov 28, 2022
@zynfly zynfly closed this Nov 28, 2022
@zynfly zynfly reopened this Nov 29, 2022
@zynfly zynfly marked this pull request as ready for review November 29, 2022 02:17
JackBoosY
JackBoosY suggested changes Nov 29, 2022
View reviewed changes
ports/llhttp/vcpkg.json Show resolved Hide resolved
ports/llhttp/portfile.cmake Show resolved Hide resolved
@zynfly @JackBoosY
Update ports/llhttp/vcpkg.json
ff10046 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
JackBoosY
JackBoosY suggested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run ./vcpkg x-add-version --overwrite-version llhttp.

ports/llhttp/portfile.cmake Show resolved Hide resolved
@zynfly @JackBoosY
Update ports/llhttp/portfile.cmake
9cb6a47 
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
@Adela0814 Adela0814 self-assigned this Nov 29, 2022
@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 29, 2022
JackBoosY
JackBoosY previously approved these changes Nov 30, 2022
View reviewed changes
Adela0814
Adela0814 suggested changes Nov 30, 2022
View reviewed changes
ports/llhttp/vcpkg.json Outdated Show resolved Hide resolved
ports/llhttp/portfile.cmake Outdated Show resolved Hide resolved
zynfly and others added 3 commits November 30, 2022 15:23
@zynfly @Adela0814
Update ports/llhttp/vcpkg.json
78ab5d6 
Co-authored-by: Mengna Li <95600143+Adela0814@users.noreply.github.com>
@zynfly
remove extra blank line
f82b0a1
@zynfly
update llhttp version
969ad25
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 30, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit c353ab2 into microsoft:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions approved these changes

@Adela0814 Adela0814 Adela0814 approved these changes

@JackBoosY JackBoosY JackBoosY left review comments

Assignees

@Adela0814 Adela0814

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zynfly @JavierMatosD @JackBoosY @Adela0814