[qtbase] no absolute paths #28360
Merged
[qtbase] no absolute paths #28360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
autoantwort
force-pushed
the
qtbase-absolute-paths1
branch
from
84741eb
to
5c44631
Compare
Neumann-A
reviewed
Dec 15, 2022
| @@ -446,3 +446,6 @@ if(EXISTS "${configfile}") | |||
| file(WRITE "${configfile}" "${_contents}") | |||
| endif() | |||
|
|
|||
| if(VCPKG_CROSSCOMPILING) | |||
| vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/share/Qt6/Qt6Dependencies.cmake" "${CURRENT_HOST_INSTALLED_DIR}" "\${CMAKE_CURRENT_LIST_DIR}/../../../${HOST_TRIPLET}") | |||
There was a problem hiding this comment.
hmm for what is this used?
There was a problem hiding this comment.
I don't know where it is included
There was a problem hiding this comment.
The file is included in vcpkg_installed/x64-osx/share/Qt6/Qt6Config.cmake
MonicaLiu0311
added
the
category:port-bug
MonicaLiu0311
previously approved these changes
Dec 22, 2022
MonicaLiu0311
added
the
info:reviewed
autoantwort
dismissed stale reviews from MonicaLiu0311 and github-actions[bot]
via
77d7c28
autoantwort
force-pushed
the
qtbase-absolute-paths1
branch
from
5c44631
to
77d7c28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #20469