Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtbase] Fix a bug that will cause deploy failed on Debug profile #28516

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

reitowo
Copy link
Contributor

@reitowo reitowo commented Dec 23, 2022

This bug will cause

qt_generate_deploy_app_script(
    TARGET VTSLink
    FILENAME_VARIABLE DEPLOY_SCRIPT
    NO_UNSUPPORTED_PLATFORM_ERROR
) 
install(SCRIPT ${DEPLOY_SCRIPT})

failed to deploy on Debug builds, as the working directory is switched to another place and not switching back, making input program not found.
This fix switch back the working directory before run windeployqt.exe

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for qtbase have changed but the version was not updated
version: 6.4.1#3
old SHA: f718070277a5feb4b54410d860556c980c5c6d82
new SHA: daf79eff476bddb5a9ad145f012bb2f46a2172f9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Dec 26, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 26, 2022
@vicroms vicroms merged commit 1c66ab1 into microsoft:master Dec 28, 2022
@reitowo reitowo deleted the fix-qtbase branch January 17, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants