Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-crt-cpp] no werror et al #28520

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

autoantwort
Copy link
Contributor

Otherwise it fails with:

[2/28] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DAWS_MQTT_WITH_WEBSOCKETS -DAWS_USE_KQUEUE -DCJSON_HIDE_SYMBOLS -DDEBUG_BUILD -I/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/aws-crt-cpp/src/c763da6810-766cf92b91.clean/include -isystem /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/include -fPIC -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -Wall -Wno-long-long -pedantic -Werror -std=gnu++11 -MD -MT CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o -MF CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o.d -o CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o -c /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/aws-crt-cpp/src/c763da6810-766cf92b91.clean/source/external/cJSON.cpp
FAILED: CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DAWS_MQTT_WITH_WEBSOCKETS -DAWS_USE_KQUEUE -DCJSON_HIDE_SYMBOLS -DDEBUG_BUILD -I/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/aws-crt-cpp/src/c763da6810-766cf92b91.clean/include -isystem /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg_installed/arm64-osx/include -fPIC -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -Wall -Wno-long-long -pedantic -Werror -std=gnu++11 -MD -MT CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o -MF CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o.d -o CMakeFiles/aws-crt-cpp.dir/source/external/cJSON.cpp.o -c /Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/aws-crt-cpp/src/c763da6810-766cf92b91.clean/source/external/cJSON.cpp
/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/buildtrees/aws-crt-cpp/src/c763da6810-766cf92b91.clean/source/external/cJSON.cpp:146:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
    sprintf(version, "%i.%i.%i", CJSON_VERSION_MAJOR, CJSON_VERSION_MINOR, CJSON_VERSION_PATCH);
    ^

github-actions[bot]
github-actions bot previously approved these changes Dec 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/aws-crt-cpp/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/aws-crt-cpp/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 26, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 26, 2022
@vicroms vicroms merged commit c8ed4ef into microsoft:master Dec 28, 2022
@autoantwort autoantwort deleted the aws-crt-cpp-no-werror branch January 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants