Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reactiveplusplus] Add new port #28729

Merged
merged 4 commits into from
Jan 9, 2023
Merged

[reactiveplusplus] Add new port #28729

merged 4 commits into from
Jan 9, 2023

Conversation

ex-purple
Copy link
Contributor

github-actions[bot]
github-actions bot previously approved these changes Jan 4, 2023
View reviewed changes
Adela0814
Adela0814 suggested changes Jan 5, 2023
View reviewed changes
ports/reactiveplusplus/vcpkg.json Outdated Show resolved Hide resolved
ports/reactiveplusplus/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814 Adela0814 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Jan 5, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2023
View reviewed changes
Adela0814
Adela0814 previously approved these changes Jan 6, 2023
View reviewed changes
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 6, 2023
dg0yt
dg0yt suggested changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the file lists from CI:
This port still needs cmake config fixup. (Then verify the usage.)
In addition, remove all CMakeLists.txt from installed /include.

@Adela0814 Adela0814 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 6, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 6, 2023
View reviewed changes
@ex-purple
Copy link
Contributor Author

ex-purple commented Jan 6, 2023 •
edited
Loading

@dg0yt , @Adela0814
The CMakeLists.txt files have been removed from the installation.
Added cmake_config_fixup command. Usage was verified on the x64_osx trippler.

@ex-purple ex-purple requested review from dg0yt and Adela0814 and removed request for dg0yt and Adela0814 January 6, 2023 16:10
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 9, 2023
@vicroms vicroms merged commit c320e71 into microsoft:master Jan 9, 2023
@ex-purple ex-purple deleted the reactiveplusplus branch January 12, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt requested changes

@github-actions GitHub Actions GitHub Actions approved these changes

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] ReactivePlusPlus
4 participants
@ex-purple @dg0yt @Adela0814 @vicroms