Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[attr] Add new port #28733

Merged
merged 3 commits into from
Jan 9, 2023
Merged

[attr] Add new port #28733

merged 3 commits into from
Jan 9, 2023

Conversation

ex-purple
Copy link
Contributor

  • What does your PR fix?

    Add new port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    linux, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/attr/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for attr have changed but the version was not updated
version: 2.5.1
old SHA: f6079a8d14a472f6a7e7b447ed2fc9e59772be75
new SHA: cd1711aba10ee7c6452f610cb33473ca8505cb2d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2023
@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 5, 2023
ports/attr/portfile.cmake Outdated Show resolved Hide resolved
ports/attr/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for attr have changed but the version was not updated
version: 2.5.1
old SHA: cd1711aba10ee7c6452f610cb33473ca8505cb2d
new SHA: 174ab32c16a4f113939335dbf59eb8791ad2374c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for attr have changed but the version was not updated
version: 2.5.1
old SHA: cd1711aba10ee7c6452f610cb33473ca8505cb2d
new SHA: 99ae42f2118c5c6d128b332dd5e914aeba6702d9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

versions/a-/attr.json Outdated Show resolved Hide resolved
ex-purple and others added 2 commits January 5, 2023 12:21
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
@ex-purple
Copy link
Contributor Author

@FrankXie05
Looks like info:reviewed label is missing here.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jan 9, 2023
@vicroms vicroms merged commit 17f9ced into microsoft:master Jan 9, 2023
@ex-purple ex-purple deleted the attr branch January 12, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants