Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk-cpp] no werror et al #29133

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

autoantwort
Copy link
Contributor

Werror breaks the build on my mac for some features.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/aws-sdk-cpp/vcpkg.json

Valid values for the license field can be found in the documentation

@vicroms vicroms added the info:reviewed Pull Request changes follow basic guidelines label Jan 23, 2023
@BillyONeal BillyONeal merged commit 77a36d8 into microsoft:master Jan 23, 2023
@BillyONeal
Copy link
Member

Thanks!

@autoantwort autoantwort deleted the aws-sdk-cpp-no-werror branch January 23, 2023 23:52
@dg0yt dg0yt mentioned this pull request Feb 13, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants