Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtmfp-cpp] Added rtmfp-cpp library #29442

Merged
merged 24 commits into from
Mar 2, 2023
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ports/rtmfp-cpp/portfile.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO zenomt/rtmfp-cpp
REF "v${VERSION}"
SHA512 eea3e4b52a4639dce3ff3f88011ae5b2f07dbeb7237f854b9b3f1a829c04af930c8edfa3a1a3cad95890a372fc6cc436b00c4dadf9b06fc404f50bdd36634a08
HEAD_REF main
)

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
)

vcpkg_cmake_install()
vcpkg_cmake_config_fixup (CONFIG_PATH lib/cmake/rtmfp)
vcpkg_copy_pdbs()

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share")

# Copyright and license
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
19 changes: 19 additions & 0 deletions ports/rtmfp-cpp/vcpkg.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "rtmfp-cpp",
"version": "1.4.0-20230213.18168ec",
"description": "Secure Real-Time Media Flow Protocol Library (RTMFP)",
"homepage": "https://github.com/zenomt/rtmfp-cpp",
"license": "MIT",
"supports": "x64 & !uwp",
"dependencies": [
"openssl",
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
]
}
4 changes: 4 additions & 0 deletions versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -6868,6 +6868,10 @@
"baseline": "2020-04-16",
"port-version": 3
},
"rtmfp-cpp": {
"baseline": "1.4.0-20230213.18168ec",
"port-version": 0
},
"rtmidi": {
"baseline": "5.0.0",
"port-version": 2
Expand Down
14 changes: 14 additions & 0 deletions versions/r-/rtmfp-cpp.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"versions": [
{
"git-tree": "c21433899bb0168f0573b148a2e38db27acabe66",
"version": "1.4.0-20230213.18168ec",
"port-version": 0
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt said
This must be removed anyways. A PR can add just one entry.

starting a new conversation for this since the previous one was marked "resolved" with no action. @as-shura please remove this extra section for version 1.3.0 because (1) apparently only one entry can be added per PR and (2) version 1.3.0 is unlikely to work as expected with vcpkg.

"git-tree": "e06da86339d4d4525090a61f90fab6aa0e2b61dc",
"version": "1.3.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since actual-release 1.3.0 is unlikely to work well (or at all) with vcpkg on all platforms, do you still want to leave 1.3.0 here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be removed anyways. A PR can add just one entry.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@as-shura i don't understand why you marked this conversation "resolved" without taking the required action to remove the entry for version 1.3.0, so that this PR will add only one entry (for the correct version 1.4.0-20230213.18168ec)

"port-version": 0
}
]
}