Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arg-router] Update to v1.2.2 #30024

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

cmannett85
Copy link
Contributor

@cmannett85 cmannett85 commented Mar 4, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Bug fixes
* Issue 284, specify Boost as a dependency in the config file
* Issue 274, CMake package should detect Boost headers itself

Improvements
* CMake package exported target should be namespaced (Issue 275)
* Improve CMake package config files installation (Issue 276)
@cmannett85 cmannett85 marked this pull request as ready for review March 5, 2023 08:06
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 6, 2023
@jimwang118
Copy link
Contributor

@cmannett85,Thanks for posting this PR, can you provide the full issue number?

@dg0yt
Copy link
Contributor

dg0yt commented Mar 6, 2023

@jimwang118 These are arg-router issue numbers.
@cmannett85 Normally there is no need to duplicate release notes for official upstream releases.

@jimwang118
Copy link
Contributor

@cmannett85 After the port is installed, there are only header files and no lib. Whether this port is only header files, if so, the usage should be changed to find_path() and target_include_directories().

@dg0yt
Copy link
Contributor

dg0yt commented Mar 6, 2023

Whether this port is only header files, if so, the usage should be changed to find_path() and target_include_directories().

No? If upstream provides official usage, then vcpkg can't decide something else.

@jimwang118
Copy link
Contributor

The usage has been tested successfully locally. 

find_package()
target_link_library()

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 6, 2023
@cmannett85
Copy link
Contributor Author

@cmannett85 After the port is installed, there are only header files and no lib. Whether this port is only header files, if so, the usage should be changed to find_path() and target_include_directories().

@jimwang118 arg_router is provided as a CMake package, the user just needs to find it and link their target to the imported arg_router::arg_router target - which contains the include dir and any dependent packages within its properties. The user should not, and does not, need to care about include directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants