Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yomm2 ] Bump yomm2 to 1.3.1 #30028

Merged
merged 12 commits into from Apr 19, 2023
Merged

Conversation

stellarpower
Copy link
Contributor

Existing version 1.1.2 had compile error so I have nbumped to the latest upstream tag (1.3.1)

I don't have the availability to maintain this ATM, it's not properly tested, not been built cross platforms, etc. etc. I have just changed the patches from the previous version that wouldn't apply and pushed my work up so that someone else can benefit.

Cheers

  • Changes comply with the maintainer guide
    • I think so.
  • SHA512s are updated for each updated download
  • [?] The "supports" clause reflects platforms that may be fixed by this new version
  • [?] Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
    • This removed my "port-version" from the manifest.
  • Only one version is added to each modified port's versions file.

@stellarpower
Copy link
Contributor Author

stellarpower commented Mar 5, 2023 via email

@JonLiu1993 JonLiu1993 changed the title Bump yomm2 to 1.3.1 [yomm2 ] Bump yomm2 to 1.3.1 Mar 6, 2023
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Mar 6, 2023
ports/yomm2/vcpkg.json Show resolved Hide resolved
ports/yomm2/vcpkg.json Outdated Show resolved Hide resolved
ports/yomm2/portfile.cmake Outdated Show resolved Hide resolved
@stellarpower
Copy link
Contributor Author

Thanks for the changes!

@JonLiu1993
Copy link
Member

@stellarpower, please run command ./vcpkg x-add-version yomm2 --overwrite-version and commit again.

@JonLiu1993
Copy link
Member

Ping @stellarpower for response, could you consider the review suggestion above?

@stellarpower
Copy link
Contributor Author

Sorry, really just not having the time for development right now.

That is pushed to the branch so hopefully should be visible.

Think I should have resolved the conflicts, but IDK why it's then committed this back to my branch. The conflicts should be with the base I presume.

BillyONeal
BillyONeal previously approved these changes Apr 14, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@stellarpower can you un-draft it if you think it's OK to go, or are you waiting to do something?

@JonLiu1993 It looks like your comments have been fixed, does it look good to you now?

versions/y-/yomm2.json Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

@stellarpower, After completing the above modification, please click ready for review so that we can review megre as soon as possible, Thanks.

@BillyONeal
Copy link
Member

@stellarpower Since it sounds like you are OK with this outcome can you undraft the PR?

@JonLiu1993
Copy link
Member

@stellarpower, please click ready for review so that we can review megre as soon as possible, Thanks.

@stellarpower stellarpower marked this pull request as ready for review April 17, 2023 02:14
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 19, 2023
@BillyONeal BillyONeal merged commit 28dc8b9 into microsoft:master Apr 19, 2023
12 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@stellarpower
Copy link
Contributor Author

Thanks a lot for your help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants