Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly missing include in header? #26

Closed
derpda opened this issue Jun 15, 2021 · 3 comments · Fixed by #27
Closed

Possibly missing include in header? #26

derpda opened this issue Jun 15, 2021 · 3 comments · Fixed by #27

Comments

@derpda
Copy link
Contributor

derpda commented Jun 15, 2021

It seems like include/yorel/yomm2.hpp is missing an include for std::uintptr_t!
At least on my system the compilation now fails.

std::uintptr_t is defined in <cstdint>, and adding that include fixes the issue for me.
@jll63
Copy link
Owner

jll63 commented Jun 20, 2021

Yes indeed. Hmmm that would not have arrived in D. I am going to try iwyu.

@jll63
Copy link
Owner

jll63 commented Jun 20, 2021 •
edited
Loading

@derpda If you have a minute, please review and test in your context. #27

@jll63 jll63 linked a pull request Jun 20, 2021 that will close this issue
fix include directives #27
Merged
@derpda
Copy link
Contributor Author

derpda commented Jun 21, 2021

#27 indeed fixes this!

@jll63 jll63 closed this as completed in #27 Jun 22, 2021
@stellarpower stellarpower mentioned this issue Mar 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix include directives jll63/yomm2
2 participants
@jll63 @derpda