-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libiconv] Fix android #30092
[libiconv] Fix android #30092
Conversation
@hushanjushi, could you please test it on your environment and see if it solves your problem? |
@JonLiu1993 The problems were reproducible, the PR does fix it, and the same fix is now already merged for libtasn1. No need to hold this back. |
I tested and found a puzzling error: configure: error: in `/home/test/tools/test/vcpkg/buildtrees/libiconv/x64-android-dbg':
configure: error: C compiler cannot create executables I clone dg0yt:libiconv and input:
I have set |
I met some problems when tests this pr... |
@hushanjushi Share your config.log from buildtrees/libiconv/x64-android-dbg. |
|
Not a NDK compiler.
vcpkg scripts set environment variable This PR changes source files, but not the build system. Your current problem is unrelated to this PR. |
I don't change the environment. And Is vcpkg only need |
All my recent testing is with setting |
I try again, but very confusing, fail, too. |
cmake-vars-x64-android-dbg.cmake.log no found get-cmake-vars-x64-android-dbg-CMakeCache.txt.log only get-cmake-vars-x64-android-dbg-out.log It seems like found ndk but no use? |
Yes, but this problem is not related to this PR. As expected, CMake detects the right compiler:
Check the output of |
I understand. I try again... I have set:
and link Should I set cc to ndk-clang? Yes. Work |
Can vcpkg auto set it? Or we should set CC manually for autotools in recent days? |
For now, you shall not set (Whether vcpkg should ignore the user's |
But I found CC unset will give me the not-found error... (Not ignore but i think if empty will use default cc in vcpkg? Not CC can't find is really strange) |
You must sanitize your environment. I would prefer to no longer deal with these unrelated problems here. |
Ok. I fully understand it... |
In a new VM, it works. Thank you. |
Fixes #29719. Fixes #27304.
./vcpkg x-add-version --all
and committing the result.