Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openblas] disable build in Visual Studio with feature 'dynamic-arch' #30192

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Mar 15, 2023

Fix #29994

Note: According to the upstream description:

 For the same reason it is not possible (and not necessary) to use -DDYNAMIC_ARCH=ON in a Visual Studio build) 

So disable option dynamic-arch when use build in Visual Studio cmake project.
https://github.com/xianyi/OpenBLAS/wiki/How-to-use-OpenBLAS-in-Microsoft-Visual-Studio#cmake-and-visual-studio:~:text=This%20method%20may,GNU%20(MinGW)%20ABI.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 15, 2023
@FrankXie05 FrankXie05 changed the title [Openblas] disable build in Visual Studio with feature 'Dynamic_ARCH' [openblas] disable build in Visual Studio with feature 'dynamic-arch' Mar 15, 2023
@FrankXie05 FrankXie05 marked this pull request as ready for review March 16, 2023 06:14
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Mar 16, 2023
@vicroms vicroms merged commit a4c9a64 into microsoft:master Mar 20, 2023
@FrankXie05 FrankXie05 deleted the dev/Frank/29994 branch March 21, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openblas] Build error when using dynamic-arch feature on x64-windows
3 participants