Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openblas] Fix regression on feature dynamic-arch #30638

Merged

Conversation

FabienPean-Virtonomy
Copy link
Contributor

@FabienPean-Virtonomy FabienPean-Virtonomy commented Apr 3, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Fix regression introduced by #30192 wherein the positive lookup made all other valid platform unsupported.

As far as I understood, the original problem seems purely connected to MSVC compiler, so all user-defined triplets using a compatible compiler on Windows (e.g. LLVM/Clang) will have to use --allow-unsupported, unless vcpkg has enabled the possibility to specify compiler/toolset in platform expression.

@FabienPean-Virtonomy FabienPean-Virtonomy changed the title Fix/openblas-dynamic-arch [openblas] Fix regression on feature dynamic-arch Apr 3, 2023
@FabienPean-Virtonomy
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Virtonomy"

@MonicaLiu0311 MonicaLiu0311 self-assigned this Apr 4, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 4, 2023
@FabienPean-Virtonomy
Copy link
Contributor Author

Regressions are unrelated to this PR

Downloading https://download.qt.io/archive/qt/6.4/6.4.3/submodules/qtbase-everywhere-src-6.4.3.tar.xz
warning: Download failed -- retrying after 1000ms
warning: Download failed -- retrying after 2000ms
warning: Download failed -- retrying after 4000ms
error: Failed to download from mirror set
error: https://vcpkgassetcacheeastasia.blob.core.windows.net/cache/a2d0779ba7ee8b8b78f5dc8db06177d04d50463fea7cad0b7785721acfc33dbbbaa1a7bfc052edb90ba1d11b488c30004daa43b6924a97126b9b8f82ad1a7f43?*** SECRET ***: failed: status code 403
error: https://download.qt.io/archive/qt/6.4/6.4.3/submodules/qtbase-everywhere-src-6.4.3.tar.xz: WinHttpReceiveResponse failed with exit code 12002

@Neumann-A
Copy link
Contributor

@FabienPean-Virtonomy merge with master and retrigger CI.

@vicroms vicroms merged commit 66ac2b3 into microsoft:master Apr 5, 2023
@FabienPean-Virtonomy FabienPean-Virtonomy deleted the fix/openblas-dynamic-arch branch August 11, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants