Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hpx] Update to 1.8.1 #30303

Merged
merged 6 commits into from
Mar 28, 2023
Merged

[hpx] Update to 1.8.1 #30303

merged 6 commits into from
Mar 28, 2023

Conversation

bzindovic
Copy link
Contributor

@bzindovic bzindovic commented Mar 20, 2023 •
edited
Loading

Fixes #30306.

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Mar 21, 2023
LilyWangLL
LilyWangLL requested changes Mar 21, 2023
View reviewed changes
ports/hpx/vcpkg.json Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added requires:author-response requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Mar 21, 2023
LilyWangLL
LilyWangLL requested changes Mar 21, 2023
View reviewed changes
ports/hpx/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Mar 21, 2023
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows

bzindovic and others added 2 commits March 21, 2023 12:48
@bzindovic @LilyWangLL
Update ports/hpx/vcpkg.json
f9c872e 
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@bzindovic @LilyWangLL
Update ports/hpx/portfile.cmake
34d7a89 
Co-authored-by: Lily Wang <94091114+LilyWangLL@users.noreply.github.com>
@bzindovic
Copy link
Contributor Author

@LilyWangLL I've added you suggestions to the fork. Should I mark that the this package with all the features is windows-only (original package can be built on Linux/Mac)?

@LilyWangLL
Copy link
Contributor

@LilyWangLL I've added you suggestions to the fork. Should I mark that the this package with all the features is windows-only (original package can be built on Linux/Mac)?

This is not needed, I just tested the features on windows. You should refer to the following steps to update version files of hpx.

##[error]versions/h-/hpx.json(2,): error : while parsing versions for hpx from version/h-/hpx.json
Version 1.8.1 was not found in versions file.
Run:
vcpkg x-add-version hpx
to add the new port version.
To attempt to resolve all errors at once, run:
vcpkg x-add-version --all

@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 28, 2023
@vicroms vicroms merged commit 1bbe957 into microsoft:master Mar 28, 2023
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hpx] Update to version 1.8.1
3 participants
@bzindovic @LilyWangLL @vicroms