Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[restinio] Update, fix exported config, fix build warnings #30655

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 4, 2023

Extendd version of #30578

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt mentioned this pull request Apr 4, 2023
4 tasks
@dg0yt
Copy link
Contributor Author

dg0yt commented Apr 4, 2023

The restinio CMake build system is at least unusual.

  • /: no CMakeLists.txt.
  • /dev: main cmake project. Would add extra of dependencies (via find_package or vendored copies) which are not needed for the header only lib AFAIU. (But wouldn't do that if used as part another CMake project...)
  • /dev/restinio: lib CMake project, but incomplete initialization.
  • /vcpkg: vcpkg CMake project. Adds /dev/restinio as a subdirectory. But currently lacks a project call, making find_ calls fragile.

IMO the vcpkg dir shouldn't be needed if the other project could be sufficiently configured via input variables. No vcpkg particularities should be maintained upstream.

@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 4, 2023
@jimwang118
Copy link
Contributor

The usage has been tested successfully locally.

find_package(restinio CONFIG REQUIRED)
target_link_libraries(main PRIVATE restinio::restinio)

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Apr 4, 2023
@vicroms vicroms merged commit 76b55aa into microsoft:master Apr 5, 2023
@eao197
Copy link
Contributor

eao197 commented Apr 5, 2023

@dg0yt , thanks for your help!

@dg0yt dg0yt deleted the restinio branch April 5, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants