[dumb] New port #30740
Merged
[dumb] New port #30740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
category:new-port
dg0yt
reviewed
Apr 10, 2023
Cheney-W
added
requires:author-response
and removed
info:reviewed
- Remove unofficial config since a pkg-config file is provided. - Update the match string for pkg-config fixes. - Limit ONLY_STATIC_LIBRARY to Windows.
|
Thank you for the feedback! I went ahead and removed the unofficial config since the upstream project provides a pc file and limited |
Cheney-W
reviewed
Apr 11, 2023
This dependency is no longer needed since the unofficial config was removed.
Cheney-W
approved these changes
Apr 11, 2023
Cheney-W
added
info:reviewed
|
Awesome, thanks for the new port! (I look forward to filling out policheck exceptions :P) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says. [1]./vcpkg x-add-version --alland committing the result.[1] The license provided by upstream does not seem to fit any SPDX license name, so the field in
vcpkg.jsonis left tonull. The actual license file is still installed.[2] While the initial DUMB project is no longer maintained, the original maintainer have encouraged using this fork (see the latest news on https://dumb.sourceforge.net/). According to repology.org, this fork is shipped on Arch Linux, Gentoo, Homebrew, MSYS2, and others.
DUMB can be used to parse the IT, XM, S3M, and MOD formats. The
allegro5port can be built with dumb to support these formats.This port includes an unofficial CMake target since upstream does not export any. Additionally, since no symbols are exported, the port is marked as
ONLY_STATIC_LIBRARY.I was able to build successfully and link an example program on: