Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glib] Fix build failures #31034

Merged
merged 2 commits into from
Apr 26, 2023
Merged

[glib] Fix build failures #31034

merged 2 commits into from
Apr 26, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Apr 21, 2023

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3386
Some headers are not generated early enough in concurrent builds. The patch adds dependencies.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dg0yt dg0yt mentioned this pull request Apr 22, 2023
Merged
7 tasks
@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Apr 23, 2023
@BillyONeal BillyONeal merged commit 0be3552 into microsoft:master Apr 26, 2023
@BillyONeal
Copy link
Member

Thanks for bringing us an upstream patch!

@jimwang118
Copy link
Contributor

The feature has been tested successfully locally.

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Apr 26, 2023
@dg0yt dg0yt deleted the glib branch April 26, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dg0yt @BillyONeal @jimwang118