patchelf: update to v0.18.0 #31107
Closed
patchelf: update to v0.18.0 #31107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seem to be an issue in latest release of patchelf, better wait for the fix. |
LilyWangLL
added
category:tool-update
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
|
Closing this as upstream appears unresponsive and there hasn't been activity in more than 4 months. Please feel free to reopen or open a new PR if this becomes unblocked and/or you're interested in continuing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the patchelf tool from v0.14.2 to v0.18.0.
In particular, this fixes ELF corruption on
x64-linux-dynamicwith RPATH rewriting, which manifests itself as odd segfaults on initial binary execution, or library dependencies being messed up (eg. the binary depends onlibfoo.1.2.3(& objdump/ldd/readelf displaying as such) but the runtime linker tries to load a truncatedlibf).eu-elflintreports errors likesection [ 6] '.dynstr' not fully contained in segment of program header entry 2The issues don't seem to affect all architectures and distributions evenly — eg. Fedora is much more likely to encounter runtime errors than Debian (with the same binary), as are amd64 binaries cf arm64: maybe there's some differing glibc behaviours/options at play? Presumably may depend on build path lengths and other fun variables too.
Relevant upstream issues:
normalizeNoteSegmentscauses.dynstrnot to be contained fully in a segment NixOS/patchelf#403staging-nextNixOS/patchelf#482 (fixed in Resize segment mapping rewritten sections if needed #482 NixOS/patchelf#485)