Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ada-url] Add new port #31485

Merged
merged 6 commits into from May 23, 2023
Merged

[ada-url] Add new port #31485

merged 6 commits into from May 23, 2023

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 17, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 18, 2023
@Cheney-W
Copy link
Contributor

CI failure:

D:\buildtrees\ada-url\src\v2.4.1-cb166651e1.clean\tools\cli\adaparse.cpp(223): error C2039: 'output_file': is not a member of 'fmt'
D:\buildtrees\ada-url\src\v2.4.1-cb166651e1.clean\dependencies\.cache\fmt\include\fmt/os.h(73): note: see declaration of 'fmt'
D:\buildtrees\ada-url\src\v2.4.1-cb166651e1.clean\tools\cli\adaparse.cpp(223): error C3861: 'output_file': identifier not found

Error log: https://dev.azure.com/vcpkg/public/_build/results?buildId=89565&view=artifacts&pathAsName=false&type=publishedArtifacts

@myd7349 myd7349 marked this pull request as ready for review May 21, 2023 09:42
ports/ada-url/vcpkg.json Outdated Show resolved Hide resolved
@Cheney-W Cheney-W marked this pull request as draft May 22, 2023 08:03
@Cheney-W
Copy link
Contributor

Moving the PR to draft. Please set it to "ready for review" once changes have been applied.

@myd7349
Copy link
Contributor Author

myd7349 commented May 22, 2023

Hi! @Cheney-W Thanks for your review.

@myd7349 myd7349 marked this pull request as ready for review May 22, 2023 12:03
@Cheney-W
Copy link
Contributor

Following usage test passed with x64-windows triplet:

    find_package(ada CONFIG REQUIRED)
    target_link_libraries(main PRIVATE ada::ada)

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 23, 2023
@dan-shaw dan-shaw merged commit e4e5d2d into microsoft:master May 23, 2023
15 checks passed
@myd7349 myd7349 deleted the ada-url-init branch May 24, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants