chore: add ADA_TOOLS option #413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new
ADA_TOOLS
option to allow users enable/disable the build of ada cli tools (adaparse
) manually.When trying to add a new port for
ada-url
invcpkg
, I found it failed to buildadaparse
on UWP: microsoft/vcpkg#31485 .adaparse
usesfmt::output_file
defined infmt/os.h
. However, since UWP doesn't provide _pipe,FMT_USE_FCNTL
is defined as 0, which in turn meansfmt::output_file
does not exist.https://github.com/fmtlib/fmt/blob/master/include/fmt/os.h#L23