[directxtk] fix wrong dep on arm

[autoantwort]

The dep also exists on arm, otherwise you get:

CMake Error at C:/v/vcpkg4/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  Could not find a package configuration file provided by "xaudio2redist"
  with any of the following names:

    xaudio2redistConfig.cmake
    xaudio2redist-config.cmake

[jimwang118]

Thank you for submitting this PR. Our CI does not have a testing environment. Please help confirm that there are no problems with your local testing.

[autoantwort]

There are no problems because you get an message that the dependency xaudio2redist is not supported on arm and uwp

[BillyONeal]

This seems OK to me; @walbourn as the nominal 'owner' of these ports do the edits look OK to you? Note that that dependency is already blocked so there should be no need to block it here again:

vcpkg/ports/xaudio2redist/vcpkg.json

Line 9 in 1ca3ee9

"supports": "windows & !arm & !uwp & !xbox"

[walbourn]

The xaudio2redist does not exist on arm32 or arm64. You have to use Xaudio2.9. The same is true for all UWP architectures.

What is the specific triplet and feaure being used here that is deemed a bug? Is it perhaps an upstream bug in my Cmake instead?

[walbourn]

The only time the xaudio2redist dep should be needed is building:

• -DBUILD_XAUDIO_WIN7=ON for directxtk which by definition is only x86 or x64 Win32 desktop.
• -DBUILD_XAUDIO_REDIST=ON for directxtk12 which should only ever be done for x86 or x64 scenarios Win32 desktop.
• When building for MinGW (which doesn't support ARM)

What scenario are you trying to build for ARM32 and/or ARM64?

[BillyONeal]

@autoantwort Do you have a repro?

[BillyONeal]

@walbourn I think the bug is that as written, dirextxtk12[xaudio2redist] exists on arm/uwp/xbox, but just does not actually depend on xaudio2redist. And apparently as a result cmake configs are getting minted referring to that dependency without that dependency existing.

After this PR, vcpkg install dirextxtk12[xaudio2redist] will fail with "xaudio2redist is only supported on windows & !arm & !uwp & !xbox"

[autoantwort]

@autoantwort Do you have a repro?

vcpkg x-set-installed directxtk[xaudio2redist]:arm64-windows

[autoantwort]

After this PR, vcpkg install dirextxtk12[xaudio2redist] will fail with "xaudio2redist is only supported on windows & !arm & !uwp & !xbox"

Yeah that is a better error message than a build failure because some cmake configs are not found.

[BillyONeal]

I'm interpreting @walbourn 's thumbup as "good to merge" :)