[pmdk] Fix linux compilation #33766
[pmdk] Fix linux compilation #33766
Conversation
JonLiu1993
added
category:port-feature
| "description": "Persistent Memory Development Kit", | ||
| "homepage": "https://github.com/pmem/pmdk", | ||
| "license": "BSD-3-Clause", | ||
| "supports": "!(arm | x86)", | ||
| "supports": "!(linux | arm | x86)", |
There was a problem hiding this comment.
How does this "fix linux compilation"?
It is just another incomplete port. And note that "Support for Windows and FreeBSD has been deprecated since the PMDK 1.13.0 release and was removed in the PMDK 2.0 release.", https://pmem.io/pmdk/
There was a problem hiding this comment.
In fact, it does not fix pmdk compilation under linux, because the current pmdk compilation method in vcpkg is compiled through sln files. I added supports just to tell users that linux is not supported for the time being. The supports here are really not suitable for the latest version of pmdk 2.0.0. I will upgrade to the latest version 2.0.0 later.
There was a problem hiding this comment.
And now we have a baseline regression:
REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.
There was a problem hiding this comment.
(Not to mention that msbuild doesn't support osx or android or ...)
There was a problem hiding this comment.
Where did you see this REGRESSION?
REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.
There was a problem hiding this comment.
Fixes #15896
Pmdk compilation methods are compiled through sln files, so linux is not supported
SHA512s are updated for each updated downloadAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.