Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ffmpeg] fix feature vpx #33796

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[ffmpeg] fix feature vpx #33796

merged 1 commit into from
Sep 19, 2023

Conversation

autoantwort
Copy link
Contributor

Fixes #31118, #33777

@talregev
Copy link
Contributor

talregev commented Sep 15, 2023 •
edited
Loading

@autoantwort Thank you for the fix.
Can you also update it to version 6 in next PR?

@autoantwort
Copy link
Contributor Author

Can you also update it to version 6 in next PR?

I have no interest in it and there is #30135

@talregev
Copy link
Contributor

Can you also update it to version 6 in next PR?

I have no interest in it and there is #30135

I already know about this PR, but it seems that the owner give up on this update.

@Sibras
Copy link
Contributor

Sibras commented Sep 16, 2023

It should be pointed out that all the decoder/encoder dependencies only effect avcodec. So I would expect that you could probably get similar issues with ffmpeg[core,x264] or ffmpeg[core,mp3lame] etc.
Also other deps only effect things like avdevice or avfilter in similar ways

@autoantwort
Copy link
Contributor Author

I have tested the other features and only the vpx feature failed to build. Maybe the other feature will silently not work but build successfully.

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 18, 2023
@MonicaLiu0311
Copy link
Contributor

Feature vpx is tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Sep 19, 2023
@vicroms vicroms merged commit 335c1d1 into microsoft:master Sep 19, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ffmpeg] Build failue
5 participants
@autoantwort @talregev @Sibras @MonicaLiu0311 @vicroms