Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openvdb] Add nanovdb feature #34224

Merged
merged 8 commits into from
Oct 4, 2023
Merged

[openvdb] Add nanovdb feature #34224

merged 8 commits into from
Oct 4, 2023

Conversation

eclipse0922
Copy link
Contributor

@eclipse0922 eclipse0922 commented Oct 3, 2023 •
edited
Loading

Update openvdb port to enable the optional nanovdb feature.

https://github.com/AcademySoftwareFoundation/openvdb/blob/master/doc/nanovdb/HowToBuild.md

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
    - [] The "supports" clause reflects platforms that may be fixed by this new version
    - [] Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

BillyONeal
BillyONeal requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicks :)

ports/openvdb/fix_nanovdb.patch Outdated Show resolved Hide resolved
ports/openvdb/portfile.cmake Outdated Show resolved Hide resolved
ports/openvdb/portfile.cmake Show resolved Hide resolved
ports/openvdb/fix_nanovdb.patch Show resolved Hide resolved
@BillyONeal BillyONeal marked this pull request as draft October 4, 2023 00:47
@eclipse0922 @BillyONeal
Update ports/openvdb/portfile.cmake
f7912e9 
use ${FEATURE_OPTIONS} variable

Co-authored-by: Billy O'Neal <bion@microsoft.com>
eclipse0922
eclipse0922 commented Oct 4, 2023
View reviewed changes
versions/o-/openvdb.json Outdated Show resolved Hide resolved
@eclipse0922 eclipse0922 marked this pull request as ready for review October 4, 2023 02:00
dg0yt
dg0yt reviewed Oct 4, 2023
View reviewed changes
ports/openvdb/portfile.cmake Outdated Show resolved Hide resolved
ports/openvdb/fix_nanovdb.patch Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

Thanks for your review @dg0yt!

@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Oct 4, 2023
@eclipse0922
Copy link
Contributor Author

I appreciate both of you. @dg0yt @BillyONeal

@BillyONeal BillyONeal merged commit be2d7f8 into microsoft:master Oct 4, 2023
15 checks passed
@eclipse0922 eclipse0922 deleted the nanovdb branch October 4, 2023 06:11
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
@eclipse0922 @clementperon
[openvdb] Add nanovdb feature (microsoft#34224)
e407c49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eclipse0922 @BillyONeal @dg0yt