Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gstreamer] add feature to enable aom support #35680

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

marcbull
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 14, 2023
@LilyWangLL
Copy link
Contributor

This feature build failed on x64-windows with the following error:

../src/1.22.5-76261fda2d.clean/subprojects/gst-plugins-bad/ext/aom/gstav1dec.c(62): error C2121: '#': invalid character: possibly the result of a macro expansion
../src/1.22.5-76261fda2d.clean/subprojects/gst-plugins-bad/ext/aom/gstav1dec.c(62): error C2059: syntax error: 'if'
../src/1.22.5-76261fda2d.clean/subprojects/gst-plugins-bad/ext/aom/gstav1dec.c(62): error C2059: syntax error: '}'

@LilyWangLL LilyWangLL marked this pull request as draft December 14, 2023 10:30
@LilyWangLL
Copy link
Contributor

Feature gstreamer[aom] passed on x64-linux.

@LilyWangLL LilyWangLL marked this pull request as ready for review December 15, 2023 06:08
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Dec 15, 2023
@vicroms vicroms merged commit 9021cb0 into microsoft:master Dec 15, 2023
15 checks passed
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* [gstreamer] add feature to enable aom support

* Update version database

* [gstreamer] disable aom feature on windows

* Update version database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants