Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openssl] Disable building quicserver utility. #35838

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[openssl] Disable building quicserver utility. #35838

merged 2 commits into from
Jan 4, 2024

Conversation

AenBleidd
Copy link
Contributor

Thix fixes #35792.

@AenBleidd AenBleidd mentioned this pull request Dec 22, 2023
Closed
@Adela0814 Adela0814 removed the request for review from JonLiu1993 December 25, 2023 01:43
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 25, 2023
JonLiu1993
JonLiu1993 previously approved these changes Dec 25, 2023
View reviewed changes
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 25, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Dec 25, 2023

Can this be transformed into a change which can be upstreamed?

@AenBleidd
Copy link
Contributor Author

@dg0yt, technically, there are two possible alternatives:

  1. Disable building quicserver with the configure flag (faster)
  2. Fix building quicserver by passing correct flags (harder and longer, and I really don't think it's needed for vcpkg).

If you think it's valuable - I can try to do that this week.

@AenBleidd AenBleidd force-pushed the vko_fix_openssl_remove_quicserver branch from a393311 to e28304f Compare December 25, 2023 12:12
@AenBleidd
Copy link
Contributor Author

PR has been updated. The same changes are proposed upstream: openssl/openssl#23149

@AenBleidd AenBleidd force-pushed the vko_fix_openssl_remove_quicserver branch from e28304f to 33e8740 Compare December 25, 2023 12:20
@AenBleidd
Copy link
Contributor Author

Linux failure doesn't look related to the change:

-- Could NOT find SASL2 (missing: SASL2_VERSION SASL2_INCLUDE_DIR SASL2_LIBRARY) (Required is at least version "2.0")
-- Using SASL backend : NOTFOUND

@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label Dec 26, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Dec 26, 2023

mongo-c-driver? It is not related to this PR. The actual error is

CMake Error at build/cmake/LoadVersion.cmake:9 (string):
  string sub-command REGEX, mode MATCHALL needs at least 5 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:20 (LoadVersion)

I got the same error in another PR. It might be a race condition from parallel configuration.

@AenBleidd AenBleidd force-pushed the vko_fix_openssl_remove_quicserver branch 3 times, most recently from e5d5724 to cc1fda5 Compare December 27, 2023 15:02
@AenBleidd
[openssl] Disable building quicserver utility.
9e6b184 
Thix fixes microsoft#35792.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd AenBleidd force-pushed the vko_fix_openssl_remove_quicserver branch from cc1fda5 to 9e6b184 Compare December 27, 2023 15:36
@AenBleidd
Copy link
Contributor Author

The corresponding patch was approved and merged to the OpenSSL master and 3.2 branches.
I assume, this PR could be merged as well. Once OpenSSL releases a new version with this patch included - the patch added from this PR could be removed by the OpenSSL port maintainer.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 4, 2024
@BillyONeal BillyONeal merged commit baa9580 into microsoft:master Jan 4, 2024
15 checks passed
@BillyONeal
Copy link
Member

BillyONeal commented Jan 4, 2024 •
edited
Loading

Thanks for running this back with upstream! (And fixing it, of course)

@AenBleidd AenBleidd deleted the vko_fix_openssl_remove_quicserver branch January 4, 2024 22:26
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@AenBleidd @Osyotr
[openssl] Disable building quicserver utility. (microsoft#35838)
c9fcd86 
Thix fixes microsoft#35792.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
Co-authored-by: vzhli17 <v-zhli17@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 left review comments

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[openssl] Build error on Android arm/armv6/x86 of OpenSSL 3.2.0 (regression after update from OpenSSL 3.1.4)
4 participants
@AenBleidd @dg0yt @BillyONeal @JonLiu1993